From owner-svn-src-head@FreeBSD.ORG Thu Mar 12 21:29:46 2015 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B933825D; Thu, 12 Mar 2015 21:29:46 +0000 (UTC) Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9D638D6F; Thu, 12 Mar 2015 21:29:46 +0000 (UTC) Received: from aurora.physics.berkeley.edu (aurora.Physics.Berkeley.EDU [128.32.117.67]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id t2CLThUV011380 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 12 Mar 2015 14:29:44 -0700 Message-ID: <55020547.7050102@freebsd.org> Date: Thu, 12 Mar 2015 14:29:43 -0700 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Konstantin Belousov Subject: Re: svn commit: r279937 - in head/sys/powerpc: include powerpc References: <201503122115.t2CLFdmi026986@svn.freebsd.org> <20150312212234.GS2379@kib.kiev.ua> In-Reply-To: <20150312212234.GS2379@kib.kiev.ua> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Sonic-CAuth: UmFuZG9tSVYHdlxUMw4Jz1i2Ach4KZlyLTNiYp9PrFe0SKIrqfwPnznqijxI+vhgWN46zgROo8a51T/XLl8Djo0uAZs3zG/YBKKbkQDtCwg= X-Sonic-ID: C;ai9P5v7I5BGfhb5YxQPdhw== M;lNGC5v7I5BGfhb5YxQPdhw== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2015 21:29:46 -0000 On 03/12/15 14:22, Konstantin Belousov wrote: > On Thu, Mar 12, 2015 at 09:15:39PM +0000, Nathan Whitehorn wrote: >> Author: nwhitehorn >> Date: Thu Mar 12 21:15:38 2015 >> New Revision: 279937 >> URL: https://svnweb.freebsd.org/changeset/base/279937 >> >> Log: >> Provide VSX context in ucontext(3) API. >> >> Modified: >> head/sys/powerpc/include/ucontext.h >> head/sys/powerpc/powerpc/exec_machdep.c >> >> Modified: head/sys/powerpc/include/ucontext.h >> ============================================================================== >> --- head/sys/powerpc/include/ucontext.h Thu Mar 12 20:14:48 2015 (r279936) >> +++ head/sys/powerpc/include/ucontext.h Thu Mar 12 21:15:38 2015 (r279937) >> @@ -46,6 +46,7 @@ typedef struct __mcontext { >> uint32_t mc_av[2]; >> register_t mc_frame[42]; >> uint64_t mc_fpreg[33]; >> + uint64_t mc_vsxfpreg[32]; /* low-order half of VSR0-31 */ >> } mcontext_t __aligned(16); >> >> #if defined(_KERNEL) && defined(__powerpc64__) >> @@ -60,6 +61,7 @@ typedef struct __mcontext32 { >> uint32_t mc_av[2]; >> uint32_t mc_frame[42]; >> uint64_t mc_fpreg[33]; >> + uint64_t mc_vsxfpreg[32]; /* low-order half of VSR0-31 */ >> } mcontext32_t __aligned(16); >> #endif > It looks as if you broken the ABI compatibility by the change. Am I wrong ? > That is correct. It's a tier-2 platform and -CURRENT, so I'm not sure it's worth the compatibility shims. I'm happy to add them if you think otherwise. -Nathan