Date: Tue, 10 Feb 2009 14:52:48 +0100 From: Paolo Pisati <p.pisati@oltrelinux.com> To: Randall Stewart <rrs@lakerest.net> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Chagin Dmitry <dchagin@freebsd.org> Subject: Re: svn commit: r188388 - head/sys/netinet Message-ID: <499186B0.6030109@oltrelinux.com> In-Reply-To: <32F47187-B1D5-4EE3-A1ED-0FE4CD5998AC@lakerest.net> References: <200902091142.n19BgNnb059032@svn.freebsd.org> <20090209124141.GA2071@dchagin.static.corbina.ru> <32F47187-B1D5-4EE3-A1ED-0FE4CD5998AC@lakerest.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Randall Stewart wrote: > Hmm.. > > My guess is it has to do with the NAT stuff that > Paolo is working on. Basically the ipfw/nat is becoming > SCTP aware and I believe we made the sctp_crc32c routines > public so that he could access them. > > Paolo: maybe you need to include <opt_sctp.h> and then do > some sort of > > #ifdef SCTP > > #endif > > Around the csum calls int crc32?? the problem with opt_scpt is that it's not available during module compilation. my other solution: -we define 2 functions ptrs: update_crc32_ptr and sctp_finalize_crc32_ptr, and initialize them with NULL -during the SCPT initialization path, we set those 2 ptrs to point to the actual SCTP functions -in alias_sctp.c, we check the value: -in case it's NULL, SCTP wasn't compiled in and thus we return 0 -else we call the pointed functions the only remaining open problem is where to put these 2 ptrs: it has to be a place that is always compiled in, but on the other hand we should limit pollution.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?499186B0.6030109>