From owner-cvs-ports@FreeBSD.ORG Thu Sep 4 09:31:57 2003 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 22EC716A4BF; Thu, 4 Sep 2003 09:31:57 -0700 (PDT) Received: from dragon.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2F26D43FFB; Thu, 4 Sep 2003 09:31:56 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.9/8.12.9) with ESMTP id h84GVtnW000583; Thu, 4 Sep 2003 09:31:55 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.9/8.12.9/Submit) id h84GVtDu000582; Thu, 4 Sep 2003 09:31:55 -0700 (PDT) (envelope-from obrien) Date: Thu, 4 Sep 2003 09:31:54 -0700 From: "David O'Brien" To: Joe Marcus Clarke Message-ID: <20030904163154.GA554@dragon.nuxi.com> References: <200309040348.h843m4Ri056285@repoman.freebsd.org> <20030904083135.GA56128@dragon.nuxi.com> <1062692611.698.1.camel@gyros> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1062692611.698.1.camel@gyros> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.1-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-ports@FreeBSD.org cc: cvs-all@FreeBSD.org cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/Mk bsd.gnome.mk X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Sep 2003 16:31:57 -0000 On Thu, Sep 04, 2003 at 12:23:31PM -0400, Joe Marcus Clarke wrote: > On Thu, 2003-09-04 at 04:31, David O'Brien wrote: > > On Wed, Sep 03, 2003 at 08:48:04PM -0700, Joe Marcus Clarke wrote: > > > marcus 2003/09/03 20:48:04 PDT > > > > > > FreeBSD ports repository > > > > > > Modified files: > > > Mk bsd.gnome.mk > > > Log: > > > Back out the previous commit. It was not approved, looks like was an > > > accidental commit based on the commit log, and was committed to the > > > deprecated macros section. > > > > It was an accident, but it was also something you said could be committed > > about a year ago. > > Not me (I wasn't a committer years ago). Only about a year ago -- someone on gnome@freebsd.org said that sobomax wasn't the only GNOME guy and the patch was fine (back when he refused to commit it). > What problem is it trying to > solve? The X libraries are automatically depended on if you use gtk12 > or gtk20. I looked at this a little last night, and I couldn't see a > make package-depends output that was different with this option. Do you > have an example port? ports/editors/vim -- I have to do this: .if defined(WITH_GNOME) USE_XLIB= yes .endif it may also be that the world has moved forward to the point that I can remove this hack from vim/Makefile and I just didn't know it. -- -- David (obrien@FreeBSD.org)