From owner-cvs-all Sun Jan 6 13:22:52 2002 Delivered-To: cvs-all@freebsd.org Received: from straylight.ringlet.net (discworld.nanolink.com [217.75.135.248]) by hub.freebsd.org (Postfix) with SMTP id 3C1B137B41A for ; Sun, 6 Jan 2002 13:22:32 -0800 (PST) Received: (qmail 4689 invoked by uid 1000); 6 Jan 2002 20:22:23 -0000 Date: Sun, 6 Jan 2002 22:22:23 +0200 From: Peter Pentchev To: Dag-Erling Smorgrav Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libfetch Makefile common.c common.h fetch.3 fetch.c fetch.h file.c ftp.c http.c Message-ID: <20020106222223.F314@straylight.oblivion.bg> Mail-Followup-To: Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200112180944.fBI9ioK99527@freefall.freebsd.org> <20011225162803.C304@straylight.oblivion.bg> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20011225162803.C304@straylight.oblivion.bg>; from roam@ringlet.net on Tue, Dec 25, 2001 at 04:28:03PM +0200 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, This is still an issue: libfetch does not compile on -stable with WARNS_WERROR set. I guess it would not compile on -current, either, was it not for David O'Brien's changing the WARNS granularity, so WARNS=2 is 'mostly harmless' now :) G'luck, Peter -- You have, of course, just begun reading the sentence that you have just finished reading. On Tue, Dec 25, 2001 at 04:28:03PM +0200, Peter Pentchev wrote: > On Tue, Dec 18, 2001 at 01:44:50AM -0800, Dag-Erling Smorgrav wrote: > > des 2001/12/18 01:44:50 PST > > > > Modified files: (Branch: RELENG_4) > > lib/libfetch Makefile common.c common.h fetch.3 > > fetch.c fetch.h file.c ftp.c http.c > > Log: > > MFC: synch with -CURRENT (authentication callbacks, redirect to FTP URLs, > > verbosity, various small bug fixes, warnings and style, version bump). > > This does not quite compile with WARNS_WERROR, due to some constness > in uio.h structs. The attached patch fixes a WERROR build. > Unfortunately, I do not think this can be resolved without separating > the readv() and writev() argument structs, constifying the writev() one > and introducing a gross incompatibility with all the Unix-like OS's > out there.. > > G'luck, > Peter > > -- > This sentence no verb. > > Index: lib/libfetch/Makefile > =================================================================== > RCS file: /home/ncvs/src/lib/libfetch/Makefile,v > retrieving revision 1.14.2.4 > diff -u -r1.14.2.4 Makefile > --- lib/libfetch/Makefile 18 Dec 2001 09:44:49 -0000 1.14.2.4 > +++ lib/libfetch/Makefile 20 Dec 2001 16:50:43 -0000 > @@ -2,7 +2,7 @@ > > MAINTAINER= des@freebsd.org > LIB= fetch > -WARNS?= 2 > +WARNS?= 1 > CFLAGS+= -I. > CFLAGS+= -DINET6 > SRCS= fetch.c common.c ftp.c http.c file.c \ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message