From owner-cvs-all@FreeBSD.ORG  Tue Sep 19 18:31:25 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8BF3316A403;
	Tue, 19 Sep 2006 18:31:25 +0000 (UTC)
	(envelope-from jkim@FreeBSD.org)
Received: from anuket.mj.niksun.com (gwnew.niksun.com [65.115.46.162])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 174F943D73;
	Tue, 19 Sep 2006 18:31:20 +0000 (GMT)
	(envelope-from jkim@FreeBSD.org)
Received: from niksun.com (anuket [10.70.0.5])
	by anuket.mj.niksun.com (8.13.1/8.13.1) with ESMTP id k8JIVDew053284;
	Tue, 19 Sep 2006 14:31:13 -0400 (EDT)
	(envelope-from jkim@FreeBSD.org)
From: Jung-uk Kim <jkim@FreeBSD.org>
To: John Baldwin <jhb@FreeBSD.org>
Date: Tue, 19 Sep 2006 14:30:59 -0400
User-Agent: KMail/1.6.2
References: <200609182218.k8IMIMUT059300@repoman.freebsd.org>
	<200609181901.47414.jkim@FreeBSD.org>
	<200609191352.37338.jhb@freebsd.org>
In-Reply-To: <200609191352.37338.jhb@freebsd.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200609191431.01649.jkim@FreeBSD.org>
X-Virus-Scanned: ClamAV 0.88/1900/Tue Sep 19 13:32:20 2006 on
	anuket.mj.niksun.com
X-Virus-Status: Clean
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	"Christian S.J. Peron" <csjp@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/bge if_bge.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Sep 2006 18:31:25 -0000

On Tuesday 19 September 2006 01:52 pm, John Baldwin wrote:
> On Monday 18 September 2006 19:01, Jung-uk Kim wrote:
> > On Monday 18 September 2006 06:33 pm, Christian S.J. Peron wrote:
> > > Jung-uk Kim wrote:
> > > > jkim        2006-09-18 22:18:22 UTC
> > > >
> > > >   FreeBSD src repository
> > > >
> > > >   Modified files:
> > > >     sys/dev/bge          if_bge.c
> > > >   Log:
> > > >   Do not strip VLAN tag in promiscuous mode.
> > > >
> > > >   Revision  Changes    Path
> > > >   1.148     +28 -15    src/sys/dev/bge/if_bge.c
> > >
> > > I don't think this is right. An interface does not have to be
> > > in promiscuous mode in order to have BPF peers attached to it.
> > > If this is being done to ensure that vlan info is preserved for
> > > things like tcpdump, the correct fix is to use
> > > bpf_peers_present() instead.
> >
> > Yes, I know that.  This is just a stopgap until we have 'correct'
> > fix. BTW, I am just following bad example, i.e., em(4). ;-)
>
> Which I'm about to kill hopefully.  Please let's fix this the right
> way and not hack it any further.

Sure, no problem.  But I don't think we can DTRT on -STABLE without 
breaking API.  Can we?

Jung-uk Kim