From owner-svn-src-all@freebsd.org  Mon May 21 20:49:26 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1AF32EFDEFF;
 Mon, 21 May 2018 20:49:26 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id BDDE46FAC4;
 Mon, 21 May 2018 20:49:25 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: from mail-it0-f44.google.com (mail-it0-f44.google.com
 [209.85.214.44])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 (Authenticated sender: mmacy)
 by smtp.freebsd.org (Postfix) with ESMTPSA id 833C218C45;
 Mon, 21 May 2018 20:49:25 +0000 (UTC)
 (envelope-from mmacy@freebsd.org)
Received: by mail-it0-f44.google.com with SMTP id n64-v6so22638738itb.3;
 Mon, 21 May 2018 13:49:25 -0700 (PDT)
X-Gm-Message-State: ALKqPwdmcGXoyWPG9V3gjhD+tdHo30hBQ5uTvxC70I3KPYB3NTpKjlfX
 xM5VwJ+ZtbnDska98xVlFSmp6o7pzGK5KhO1Rfw=
X-Google-Smtp-Source: AB8JxZqJAO775xEkzlxBOmDdyawxD+96tXHo7Ub4Fl9hI4Bx2hQy/4+FlDhENNoGisHr8jz1jOCRr5ITSoTX+K2ta7Q=
X-Received: by 2002:a24:5b54:: with SMTP id g81-v6mr367900itb.7.1526935764934; 
 Mon, 21 May 2018 13:49:24 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a02:85ae:0:0:0:0:0 with HTTP; Mon, 21 May 2018 13:49:24
 -0700 (PDT)
In-Reply-To: <CADrOrmsP6e_nepCzv__qeknPPy7evB+gbb5pbU_-z6Lurs7nCg@mail.gmail.com>
References: <201805200227.w4K2Rwhh007423@repo.freebsd.org>
 <CADrOrmsP6e_nepCzv__qeknPPy7evB+gbb5pbU_-z6Lurs7nCg@mail.gmail.com>
From: Matthew Macy <mmacy@freebsd.org>
Date: Mon, 21 May 2018 13:49:24 -0700
X-Gmail-Original-Message-ID: <CAPrugNr2YUFtpMbXWQpxfqjPWmQeQGuN2B0zbp7F14J3Se9x8g@mail.gmail.com>
Message-ID: <CAPrugNr2YUFtpMbXWQpxfqjPWmQeQGuN2B0zbp7F14J3Se9x8g@mail.gmail.com>
Subject: Re: svn commit: r333911 - head/sys/netinet
To: Jonathan Looney <jonlooney@gmail.com>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 May 2018 20:49:26 -0000

On Mon, May 21, 2018 at 6:15 AM, Jonathan Looney <jonlooney@gmail.com> wrote:
> On Sat, May 19, 2018 at 10:27 PM, Matt Macy <mmacy@freebsd.org> wrote:
>>
>> +       il = malloc(sizeof(struct in_pcblist) + n * sizeof(struct inpcb
>> *), M_TEMP, M_WAITOK|M_ZERO);
>> +       inp_list = il->il_inp_list;
>
>
> Why does this need M_ZERO?

It allows me to assert that it hasn't already been passed to
epoch_call. However, it doesn't make sense to pass it on
non-INVARIANTS builds.

-M