Date: Sun, 16 Jun 2002 16:54:58 +1000 From: Tim Robbins <tjr@FreeBSD.ORG> To: Joe Marcus Clarke <marcus@FreeBSD.ORG> Cc: dougb@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: [PATCH] sed is broken in -CURRENT Message-ID: <20020616165458.A10075@dilbert.robbins.dropbear.id.au> In-Reply-To: <3D0C30CA.216164DE@FreeBSD.org>; from DougB@FreeBSD.ORG on Sat, Jun 15, 2002 at 11:31:38PM -0700 References: <1024202502.81450.13.camel@shumai.marcuscom.com> <3D0C30CA.216164DE@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 15, 2002 at 11:31:38PM -0700, Doug Barton wrote: > Joe Marcus Clarke wrote: > > > > After the recent round of -i fixes to sed, certain ports will no longer > > make configure (gaim being a prime example). The problem is that > > mf_fgets() is unnecessarily overwriting sp->len. The attached patch > > corrects the problem while still allowing -i to work on multiple files. > > > > As a ports committer, I can't do anything but let you guys (and gals) > > know. > > Just like any other user, you can file a PR. And given that you're a > committer, you can then assign it to whoever broke the things your patch > fixes. There is already a PR open for this issue: bin/39310 . It is assigned to sobomax becauses his streamlining of the file processing code inadvertently caused the incorrect behaviour. Such are the perils of using -CURRENT for anything but development and testing :) Tim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020616165458.A10075>