Date: Wed, 12 May 2010 16:40:30 -0400 From: Wesley Shields <wxs@FreeBSD.org> To: Garrett Cooper <yanefbsd@gmail.com> Cc: cvs-ports@FreeBSD.org, Doug Barton <dougb@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/ports-mgmt/portmaster/files portmaster.sh.in Message-ID: <20100512204030.GC2474@atarininja.org> In-Reply-To: <6324EA09-E6E9-4374-A57C-3A48326A5F4D@gmail.com> References: <201005102323.o4ANNjhS089001@repoman.freebsd.org> <6324EA09-E6E9-4374-A57C-3A48326A5F4D@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 10, 2010 at 09:20:31PM -0400, Garrett Cooper wrote: > On May 10, 2010, at 7:23 PM, Doug Barton <dougb@FreeBSD.org> wrote: > > > dougb 2010-05-10 23:23:45 UTC > > > > FreeBSD ports repository > > > > Modified files: > > ports-mgmt/portmaster/files portmaster.sh.in > > Log: > > New Feature > > =========== > > Add a --packages-local option for those who wish to use only local > > packages, and never attempt to fetch from a remote site. > > > > Bug Fix > > ======= > > Fix a braino for --index-first and --index-only: > > The cross-checking of the command line options needs to happen before > > the environment variables are set. > > > > Cleanups And Optimizations > > ========================== > > 1. LOCALBASE_COMPAT is only ever used in combination with /pkg at the > > end, so fold that into the variable to start with. > > 2. Indicate to the user that -p is deprecated > > 3. Allow setting of DISTDIR directly in .portmasterrc like the other > > widely used vars. This entails the following: > > a. Capitalize distdir every place that it's used. > > b. Add to the list of --options to check which mean we don't even > > have to try to set it. This saves us a call to make(1). > > c. Don't set it to / if DISTDIR is empty, which makes error > > checking > > later on easier. > > d. Mark DISTDIR (and related vars) global in a few more functions > > to make it consistent. > > 4. Move the test for version > 6.4 first in the list, no point in > > processing a bunch of stuff only to bail out later. > > 5. Unset the test_command_line function when we're done using it > > 6. Be smarter about whether or not to use $PM_SU_CMD to fetch the > > INDEX.bz2 > > 7. Improve cross-option error checking for the --packages* options > > > > Revision Changes Path > > 2.26 +99 -65 ports/ports-mgmt/portmaster/files/ > > portmaster.sh.in > > How about having a precedence list for download sites? Works well for > fetching ports distfiles at least. If someone doesn't want to fetch > from nonlocal mirrors they could just explicitly note the download > mirrors. And if someone wanted to place priority on the local mirror > they could accumulate the value appropriately with sh syntax. ports-mgmt/fastest_sites? -- WXS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100512204030.GC2474>