From owner-freebsd-mips@FreeBSD.ORG Tue Jun 16 17:47:42 2015 Return-Path: Delivered-To: freebsd-mips@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D6A26133 for ; Tue, 16 Jun 2015 17:47:42 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-ig0-x235.google.com (mail-ig0-x235.google.com [IPv6:2607:f8b0:4001:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A116020C for ; Tue, 16 Jun 2015 17:47:42 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by igbiq7 with SMTP id iq7so48590979igb.1 for ; Tue, 16 Jun 2015 10:47:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=aBAqTZiSSXzuhqTIXYaK/pkpMb8yUTiE4MvlqHzVoJU=; b=Zu4NtY/9n7Yqrf7C3zrRy2eWB/kjS2TGomMfhz4KXt9XSYOFb7OQGdepEOtnmVYd3Y 14r3SU85BSXuo8bV+2LCvcChkfDX861mOTiaj97HMVnHwxBOafrRitedovMlwBqG9Jbf VMh+mt5No6EqP/ayczBQT+fNuRcsdjBpheDTEdra4dgvyNGPTprq8R0altpFQ/EHkE2/ oILokegszZAuke5f24MC15ue25QEyIoJreYrXSFfLh97gip9lsIR98Ip/FYeR3GF+7UT eOXeUAi4vAWye/SweFFMN7oEzXwQ/IGX2JMDGerw7+r00Y0HCd5SVLtJvWp2Oqro/I63 WJ/Q== MIME-Version: 1.0 X-Received: by 10.50.78.232 with SMTP id e8mr19212183igx.32.1434476861961; Tue, 16 Jun 2015 10:47:41 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.36.38.133 with HTTP; Tue, 16 Jun 2015 10:47:41 -0700 (PDT) In-Reply-To: <20150616011832.146e0f0e@kan> References: <20150616011832.146e0f0e@kan> Date: Tue, 16 Jun 2015 10:47:41 -0700 X-Google-Sender-Auth: F3tLmPirFq02IoTo6-AiC13Y0OU Message-ID: Subject: Re: [rfc] fix umul_ppmm() in our libgcc From: Adrian Chadd To: Alexander Kabaev Cc: "freebsd-mips@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jun 2015 17:47:42 -0000 ok, I'll give this a go tomorrow. -a On 15 June 2015 at 22:18, Alexander Kabaev wrote: > On Sat, 13 Jun 2015 15:41:34 -0700 > Adrian Chadd wrote: > >> Hi, >> >> our libgcc in -base is very .. old. It chokes when compiling for >> mips32. This patch seems to do the right thing. >> >> Does anyone have any positive/negative feedback? >> >> Thanks, >> >> >> -adrian > > Newer version of GCC use similar construct, but actual multiplication > is done using more correct selection of casts: > > UDItype __x = (UDItype) (USItype) (u) * (USItype) (v); > > I suggest you follow their lead. No objections otherwise. > > -- > Alexander Kabaev