Date: Sat, 25 Jan 2014 10:25:07 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: freebsd-ports@freebsd.org Subject: Re: What is the problem with ports PR reaction delays? Message-ID: <52E40183.3090304@freebsd.org> In-Reply-To: <20140125174835.GA67191@ithaqua.etoilebsd.net> References: <CAHcXP%2Bf6e-t--XbQPTH1goJp_CL7P=zTj5trZVWd4YZ_EsO9gw@mail.gmail.com> <52E2FA36.5080106@marino.st> <CAHcXP%2BfRDeKXjz0_sifgzeXC2dA-eDnoV5NH1yvF2D6R8JRmAg@mail.gmail.com> <52E303CB.6020304@marino.st> <CAHcXP%2Be9p2HrQ=M9HmPecMbWtXRuYPzH9kwfLGqgdrUrhvLuEA@mail.gmail.com> <52E30990.2060903@marino.st> <52E33AA7.3080205@freebsd.org> <20140125174835.GA67191@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/25/14 9:48 AM, Baptiste Daroussin wrote: > On Fri, Jan 24, 2014 at 08:16:39PM -0800, Alfred Perlstein wrote: >> >> To me it would speak of tooling as opposed to anything. >> >> Does the ports system have a 1 or 2 click interface for merging PRs like >> for instance github? >> >> Could ports take PRs in the form of pull requests on github? >> >> Wouldn't that just turn the number of updates into a few minor clicks? >> >> (also wouldn't it make it easier for ports submitters)? >> >> (maybe there is some great ports system that I'm not aware of that makes >> this all as easy github, but I somehow doubt that.) > That would imho be a total disaster, as less and less people will really take > care of reviewing the actual patch (lots of commits are already directly from Pr > patches without applying some necessary diff for consistency, correctness, Q/A > and cosmetic.) > > You are not serious. You are saying that because the process would be too streamlined that quality would be impacted? That is pretty entertaining. I've seen such positions, but only at very large and derpy companies coming from people invested in broken tooling. > btw we already have tons of tools available to just merge patches directly from > gnats. Are any of these tools available on the other side? Ie, for port submitters? -Alfred
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52E40183.3090304>