Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Jun 2007 22:01:38 -0400
From:      Kris Kennaway <kris@obsecurity.org>
To:        Maxim Sobolev <sobomax@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, Pav Lucistnik <pav@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Kris Kennaway <kris@obsecurity.org>
Subject:   Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c
Message-ID:  <20070620020138.GA2486@rot13.obsecurity.org>
In-Reply-To: <4678663E.2060204@FreeBSD.org>
References:  <200706182249.l5IMnE4H099470@repoman.freebsd.org> <467863E0.2040906@FreeBSD.org> <20070619232125.GA750@rot13.obsecurity.org> <4678653B.8070409@FreeBSD.org> <20070619232451.GA872@rot13.obsecurity.org> <4678663E.2060204@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--bp/iNruPH9dso1Pn
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 19, 2007 at 04:26:54PM -0700, Maxim Sobolev wrote:
> Kris Kennaway wrote:
> >On Tue, Jun 19, 2007 at 04:22:35PM -0700, Maxim Sobolev wrote:
> >>Kris Kennaway wrote:
> >>>On Tue, Jun 19, 2007 at 04:16:48PM -0700, Maxim Sobolev wrote:
> >>>>I have made the following patch to bring style(9) back and make code=
=20
> >>>>more readable. Do you guys want to run it on bento or could I just=20
> >>>>check it in?
> >>>>
> >>>>http://sobomax.homeunix.org/~sobomax/deps.c.diff
> >>>Is md5 checksum the same before/after?
> >>Well, it has some trivial non-whitespace changes.
> >
> >whitespace in source does not show up in the binary.
>=20
> Please re-read my message. It has NON-whitespace changes as well.

So the answer to my question is ... ?  I'm still not sure you
understood it.  If you are making no functional changes then the md5
of the resulting binary will be unchanged, and this is in fact a good
way to check whether you are introducing functional changes or just
style/whitespace changes.

Kris

--bp/iNruPH9dso1Pn
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.3 (FreeBSD)

iD8DBQFGeIqBWry0BWjoQKURAoJeAJ0Ye1ZTigmDrFfyDqh9UVkEUGRkAgCgq1qP
mfDHH5SYBrhxQ8HUQPk4y8M=
=Kg/D
-----END PGP SIGNATURE-----

--bp/iNruPH9dso1Pn--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070620020138.GA2486>