From owner-cvs-all@FreeBSD.ORG Wed Jun 20 02:01:39 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 52C9916A421; Wed, 20 Jun 2007 02:01:39 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.freebsd.org (Postfix) with ESMTP id 3A87B13C45A; Wed, 20 Jun 2007 02:01:39 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id B1ADB1A4D80; Tue, 19 Jun 2007 19:00:47 -0700 (PDT) Received: from rot13.obsecurity.org (rot13.obsecurity.org [192.168.1.5]) by obsecurity.dyndns.org (Postfix) with ESMTP id 87ACA51264; Tue, 19 Jun 2007 22:01:38 -0400 (EDT) Received: by rot13.obsecurity.org (Postfix, from userid 1001) id 748C3C296; Tue, 19 Jun 2007 22:01:38 -0400 (EDT) Date: Tue, 19 Jun 2007 22:01:38 -0400 From: Kris Kennaway To: Maxim Sobolev Message-ID: <20070620020138.GA2486@rot13.obsecurity.org> References: <200706182249.l5IMnE4H099470@repoman.freebsd.org> <467863E0.2040906@FreeBSD.org> <20070619232125.GA750@rot13.obsecurity.org> <4678653B.8070409@FreeBSD.org> <20070619232451.GA872@rot13.obsecurity.org> <4678663E.2060204@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn" Content-Disposition: inline In-Reply-To: <4678663E.2060204@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@FreeBSD.org, Pav Lucistnik , cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Kris Kennaway Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2007 02:01:39 -0000 --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 19, 2007 at 04:26:54PM -0700, Maxim Sobolev wrote: > Kris Kennaway wrote: > >On Tue, Jun 19, 2007 at 04:22:35PM -0700, Maxim Sobolev wrote: > >>Kris Kennaway wrote: > >>>On Tue, Jun 19, 2007 at 04:16:48PM -0700, Maxim Sobolev wrote: > >>>>I have made the following patch to bring style(9) back and make code= =20 > >>>>more readable. Do you guys want to run it on bento or could I just=20 > >>>>check it in? > >>>> > >>>>http://sobomax.homeunix.org/~sobomax/deps.c.diff > >>>Is md5 checksum the same before/after? > >>Well, it has some trivial non-whitespace changes. > > > >whitespace in source does not show up in the binary. >=20 > Please re-read my message. It has NON-whitespace changes as well. So the answer to my question is ... ? I'm still not sure you understood it. If you are making no functional changes then the md5 of the resulting binary will be unchanged, and this is in fact a good way to check whether you are introducing functional changes or just style/whitespace changes. Kris --bp/iNruPH9dso1Pn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQFGeIqBWry0BWjoQKURAoJeAJ0Ye1ZTigmDrFfyDqh9UVkEUGRkAgCgq1qP mfDHH5SYBrhxQ8HUQPk4y8M= =Kg/D -----END PGP SIGNATURE----- --bp/iNruPH9dso1Pn--