Date: Thu, 30 Jun 2011 12:50:50 -0400 From: David Schultz <das@FreeBSD.ORG> To: Stefan Esser <se@FreeBSD.ORG> Cc: Alexander Best <arundel@FreeBSD.ORG>, Poul-Henning Kamp <phk@phk.freebsd.dk>, standards@FreeBSD.ORG, Bruce Evans <bde@FreeBSD.ORG> Subject: Re: RESENT with patch ... Re: [RFC] Consistent numeric range for "expr" on all architectures Message-ID: <20110630165050.GB82980@zim.MIT.EDU> In-Reply-To: <4E0CA55E.2090102@freebsd.org> References: <99048.1309258976@critter.freebsd.dk> <4E0A0774.3090004@freebsd.org> <20110629082103.O1084@besplex.bde.org> <4E0B1C47.4010201@freebsd.org> <20110630073705.P1117@besplex.bde.org> <4E0C2F41.2060302@freebsd.org> <4E0CA55E.2090102@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jun 30, 2011, Stefan Esser wrote:
> int
> +is_integer(const char *s)
> +{
> + if (*s == '-')
> + s++;
> + while (isdigit(*s))
> + s++;
> + return *s == '\0';
> +}
I only glanced at the patch for a few seconds, but your
is_integer() routine will accept a bare minus sign ("-") as an
integer.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20110630165050.GB82980>