From owner-svn-src-head@FreeBSD.ORG Wed Jan 14 15:32:53 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 17A58A3E; Wed, 14 Jan 2015 15:32:53 +0000 (UTC) Received: from mail-oi0-x22f.google.com (mail-oi0-x22f.google.com [IPv6:2607:f8b0:4003:c06::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CA4129D; Wed, 14 Jan 2015 15:32:52 +0000 (UTC) Received: by mail-oi0-f47.google.com with SMTP id z81so7815450oif.6; Wed, 14 Jan 2015 07:32:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=OZNVzr8Tn4QbXKNMyBa6ej29DpBnFem/3Un73VGZ27Y=; b=npNqqvdBUfGZqeQsos5sRTssouWnCbFRlWmyBeuWSXSlXw5PM5UfEID6dGSWU8f62f zDWji5QJ/PoGgk4YEciUzq3yDW/UcdCCMLj2BCARaDRG/Y4aG+Q9WUuNOJzDZHBpK9KV j1MP79PeHbvRFdUOfZKinW4pwJ0lnD4k7Y8Rn4MIbq9uxcEci0v1IiKnMc3LL49nWmpq Ap0Sj65ablJyKY/vWbnbHbgnNlMPJqytnU72299eonmZoDzUUe2FD+L5PHuUU82mtK7l m1Yc9+NPlLKh40NVNKREcKXRjN5JF65dvD9L3zkOlYdRKCi3OXYThJUdNq6rq2d6m4jD CJBQ== X-Received: by 10.182.153.133 with SMTP id vg5mr2882221obb.20.1421249572080; Wed, 14 Jan 2015 07:32:52 -0800 (PST) Received: from zhabar.attlocal.net (107-222-186-3.lightspeed.sntcca.sbcglobal.net. [107.222.186.3]) by mx.google.com with ESMTPSA id ve6sm12199646obb.2.2015.01.14.07.32.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Jan 2015 07:32:51 -0800 (PST) Date: Wed, 14 Jan 2015 07:32:46 -0800 From: Justin Hibbits To: John Baldwin Subject: Re: svn commit: r277163 - head/sys/dev/cardbus Message-ID: <20150114073246.74c159df@zhabar.attlocal.net> In-Reply-To: <54B67BC9.70904@FreeBSD.org> References: <201501140541.t0E5fV00070032@svn.freebsd.org> <54B67BC9.70904@FreeBSD.org> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; powerpc64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Warner Losh X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jan 2015 15:32:53 -0000 On Wed, 14 Jan 2015 09:23:05 -0500 John Baldwin wrote: > On 1/14/15 12:41 AM, Warner Losh wrote: > > Author: imp > > Date: Wed Jan 14 05:41:31 2015 > > New Revision: 277163 > > URL: https://svnweb.freebsd.org/changeset/base/277163 > > > > Log: > > Add a rather obnoxious warning if you don't have NEW_PCIB defined > > since it's a total crap shoot if things will work. > > Should we just make it a #error instead? (Some day I hope to have > NEW_PCIB enabled by default and remove the old code. Will take a > while to get there for the generic PCI code, but cardbus is probably > only used on x86 so that would be fine.) > Also powerpc, but NEW_PCIB is default there as well. - Justin