Date: Sun, 17 Nov 2013 00:20:13 GMT From: Oleg Ginzburg <olevole@olevole.ru> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/184023: emulators/virtualbox-ose doesn't compile on FreeBSD 11.0-CURRENT Message-ID: <201311170020.rAH0KDYH009434@oldred.freebsd.org> Resent-Message-ID: <201311170030.rAH0U0T2053360@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 184023
>Category: ports
>Synopsis: emulators/virtualbox-ose doesn't compile on FreeBSD 11.0-CURRENT
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sun Nov 17 00:30:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator: Oleg Ginzburg
>Release: FreeBSD 11.0-CURRENT
>Organization:
>Environment:
FreeBSD home.my.domain 11.0-CURRENT FreeBSD 11.0-CURRENT #4 r258212: Sat Nov 16 15:17:46 MSK 2013 root@home.my.domain:/usr/obj/usr/src/sys/G amd64
>Description:
compile failed with last messages:
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:404:14: error: 'free' was not declared in this scope
kmk: *** [/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/obj/VBoxSVC/src-server/freebsd/NetIf-freebsd.o] Error 1
The failing command:
@g++46 -c -O2 -g -pipe -Wshadow -Wno-long-long -Wno-variadic-macros -Wno-long-long -Wno-non-virtual-dtor -Wshadow -fshort-wchar -fpermissive -fexceptions -frtti -O2 -mtune=generic -fno-omit-frame-pointer -fno-strict-aliasing -fvisibility-inlines-hidden -fvisibility=hidden -DVBOX_HAVE_VISIBILITY_HIDDEN -DRT_USE_VISIBILITY_DEFAULT -g -pipe -Wshadow -Wno-long-long -Wno-variadic-macros -Wno-long-long -Wno-non-virtual-dtor -Wshadow -fshort-wchar -fpermissive -fexceptions -frtti -O2 -mtune=generic -fno-omit-frame-pointer -fno-strict-aliasing -fvisibility-inlines-hidden -fvisibility=hidden -DVBOX_HAVE_VISIBILITY_HIDDEN -DRT_USE_VISIBILITY_DEFAULT -m64 -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/include -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/obj/VBoxSVC -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/obj/Main/ -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/free
bsd.amd64/release/obj/VBoxAPIWrap -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main -I/usr/include -I/usr/X11R6/include -I/usr/local/include -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/bin/sdk/bindings/xpcom/include -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/bin/sdk/bindings/xpcom/include/xpcom -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/bin/sdk/bindings/xpcom/include/string -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/bin/sdk/bindings/xpcom/include/xpcom -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/bin/sdk/bindings/xpcom/include/nsprpub -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/bin/sdk/bindings/xpcom/include/ipcd -I/usr/local/include/libpng -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/include -I
/usr/ports/emulators/virtualbox-ose/work/Vir!
tualBox-4.3.0/out/freebsd.amd64/release -DVBOX -DVBOX_OSE -DVBOX_WITH_64_BITS_GUESTS -DVBOX_WITH_DEBUGGER -DRT_OS_FREEBSD -D__FREEBSD__ -DRT_ARCH_AMD64 -D__AMD64__ -DVBOX_WITH_HARDENING -DRTPATH_APP_PRIVATE=\"/usr/local/share/virtualbox-ose\" -DRTPATH_APP_PRIVATE_ARCH=\"/usr/local/lib/virtualbox\" -DRTPATH_SHARED_LIBS=\"/usr/local/lib/virtualbox\" -DRTPATH_APP_DOCS=\"/usr/local/share/doc/virtualbox-ose\" -DIN_RING3 -DUNICODE -DNDEBUG=1 -DVBOX_WITH_XPCOM -DVBOX_MAIN_SETTINGS_ADDONS -DIN_VMM_STATIC -DVBOX_WITH_GENERIC_SESSION_WATCHER -DVBOX_WITH_RAW_MODE -DVBOX_WITH_RAW_RING1 -DVBOX_WITH_NETFLT -DVBOX_WITH_CROGL -DVBOX_WITH_GUEST_PROPS -DVBOX_WITH_GUEST_CONTROL -DVBOX_WITH_USB_CARDREADER -DVBOX_WITH_HOSTNETIF_API -DVBOX_WITH_NEW_SYS_V_KEYGEN -DVBOX_WITH_VBOXSDL -DVBOX_WITH_HEADLESS -DVBOX_WITH_QTGUI -DVBOX_WITH_HGCM -DVBOX_WITH_ALSA -DVBOX_WITH_PULSE -DVBOX_WITH_E1000 -DVBOX_WITH_VIRTIO -DVBOX_WITH_AHCI -DVBOX_WITH_LSILOGIC -DVBOX_WITH_RESOURCE_USAGE_API -DVBOX_WITH_PDM_ASYNC_COMPLETI
ON -DVBOX_WITH_EXTPACK -DVBOX_WITH_VUSB -DVBOX_WITH_S3 -DVBOX_WITH_PCI_PASSTHROUGH -DVBOX_WITH_NAT_SERVICE -DVBOX_WITH_USB -DVBOX_WITH_EHCI -DVBOX_WITH_NEW_USB_CODE_ON_DARWIN -DVBOX_WITH_HOSTNETIF_API -DVBOX_USE_LIBHAL -Wp,-MD,/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/obj/VBoxSVC/src-server/freebsd/NetIf-freebsd.o.dep -Wp,-MT,/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/obj/VBoxSVC/src-server/freebsd/NetIf-freebsd.o -Wp,-MP -o /usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/obj/VBoxSVC/src-server/freebsd/NetIf-freebsd.o /usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp
*** Error code 2
Stop.
If repeat last gcc action:
g++46 -c -O2 -g -pipe -Wshadow -Wno-long-long -Wno-variadic-macros -Wno-long-long -Wno-non-virtual-dtor -Wshadow -fshort-wchar -fpermissive -fexceptions -frtti -O2 -mtune=generic -fno-omit-frame-pointer -fno-strict-aliasing -fvisibility-inlines-hidden -fvisibility=hidden -DVBOX_HAVE_VISIBILITY_HIDDEN -DRT_USE_VISIBILITY_DEFAULT -g -pipe -Wshadow -Wno-long-long -Wno-variadic-macros -Wno-long-long -Wno-non-virtual-dtor -Wshadow -fshort-wchar -fpermissive -fexceptions -frtti -O2 -mtune=generic -fno-omit-frame-pointer -fno-strict-aliasing -fvisibility-inlines-hidden -fvisibility=hidden -DVBOX_HAVE_VISIBILITY_HIDDEN -DRT_USE_VISIBILITY_DEFAULT -m64 -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/include -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/obj/VBoxSVC -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/obj/Main/ -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freeb
sd.amd64/release/obj/VBoxAPIWrap -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main -I/usr/include -I/usr/X11R6/include -I/usr/local/include -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/bin/sdk/bindings/xpcom/include -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/bin/sdk/bindings/xpcom/include/xpcom -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/bin/sdk/bindings/xpcom/include/string -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/bin/sdk/bindings/xpcom/include/xpcom -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/bin/sdk/bindings/xpcom/include/nsprpub -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/bin/sdk/bindings/xpcom/include/ipcd -I/usr/local/include/libpng -I/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/include -I/
usr/ports/emulators/virtualbox-ose/work/Virt!
ualBox-4.3.0/out/freebsd.amd64/release -DVBOX -DVBOX_OSE -DVBOX_WITH_64_BITS_GUESTS -DVBOX_WITH_DEBUGGER -DRT_OS_FREEBSD -D__FREEBSD__ -DRT_ARCH_AMD64 -D__AMD64__ -DVBOX_WITH_HARDENING -DRTPATH_APP_PRIVATE=\"/usr/local/share/virtualbox-ose\" -DRTPATH_APP_PRIVATE_ARCH=\"/usr/local/lib/virtualbox\" -DRTPATH_SHARED_LIBS=\"/usr/local/lib/virtualbox\" -DRTPATH_APP_DOCS=\"/usr/local/share/doc/virtualbox-ose\" -DIN_RING3 -DUNICODE -DNDEBUG=1 -DVBOX_WITH_XPCOM -DVBOX_MAIN_SETTINGS_ADDONS -DIN_VMM_STATIC -DVBOX_WITH_GENERIC_SESSION_WATCHER -DVBOX_WITH_RAW_MODE -DVBOX_WITH_RAW_RING1 -DVBOX_WITH_NETFLT -DVBOX_WITH_CROGL -DVBOX_WITH_GUEST_PROPS -DVBOX_WITH_GUEST_CONTROL -DVBOX_WITH_USB_CARDREADER -DVBOX_WITH_HOSTNETIF_API -DVBOX_WITH_NEW_SYS_V_KEYGEN -DVBOX_WITH_VBOXSDL -DVBOX_WITH_HEADLESS -DVBOX_WITH_QTGUI -DVBOX_WITH_HGCM -DVBOX_WITH_ALSA -DVBOX_WITH_PULSE -DVBOX_WITH_E1000 -DVBOX_WITH_VIRTIO -DVBOX_WITH_AHCI -DVBOX_WITH_LSILOGIC -DVBOX_WITH_RESOURCE_USAGE_API -DVBOX_WITH_PDM_ASYNC_COMPLETIO
N -DVBOX_WITH_EXTPACK -DVBOX_WITH_VUSB -DVBOX_WITH_S3 -DVBOX_WITH_PCI_PASSTHROUGH -DVBOX_WITH_NAT_SERVICE -DVBOX_WITH_USB -DVBOX_WITH_EHCI -DVBOX_WITH_NEW_USB_CODE_ON_DARWIN -DVBOX_WITH_HOSTNETIF_API -DVBOX_USE_LIBHAL -Wp,-MD,/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/obj/VBoxSVC/src-server/freebsd/NetIf-freebsd.o.dep -Wp,-MT,/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/obj/VBoxSVC/src-server/freebsd/NetIf-freebsd.o -Wp,-MP -o /usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/out/freebsd.amd64/release/obj/VBoxSVC/src-server/freebsd/NetIf-freebsd.o /usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp: In function 'int getDefaultIfaceIndex(short unsigned int*, int)':
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:94:39: error: 'malloc' was not declared in this scope
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:98:18: error: 'free' was not declared in this scope
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:133:30: error: 'free' was not declared in this scope
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:139:14: error: 'free' was not declared in this scope
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp: In function 'int NetIfList(std::list<ComObjPtr<HostNetworkInterface> >&)':
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:205:39: error: 'malloc' was not declared in this scope
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:209:18: error: 'free' was not declared in this scope
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:217:18: error: 'free' was not declared in this scope
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:303:14: error: 'free' was not declared in this scope
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp: In function 'int NetIfGetConfigByName(PNETIFINFO)':
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:328:39: error: 'malloc' was not declared in this scope
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:332:18: error: 'free' was not declared in this scope
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:340:18: error: 'free' was not declared in this scope
/usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp:404:14: error: 'free' was not declared in this scope
>How-To-Repeat:
make -C /usr/ports/emulators/virtualbox-ose
>Fix:
inserting stdlib.h header fix my problem
--- /usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp.orig 2013-11-17 04:11:44.000000000 +0400
+++ /usr/ports/emulators/virtualbox-ose/work/VirtualBox-4.3.0/src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp 2013-11-17 04:12:00.000000000 +0400
@@ -32,6 +32,8 @@
#include <net/if.h>
#include <net/if_types.h>
+#include <stdlib.h>
+
#include <net/route.h>
/*
* route.h includes net/radix.h which for some reason defines Free as a wrapper
Patch attached with submission follows:
Files virtualbox-ose.orig/VBoxSVC.core and virtualbox-ose/VBoxSVC.core differ
diff -ruN virtualbox-ose.orig/files/patch-src-VBox-Main-src-server-freebsd-NetIf-freebsd.cpp virtualbox-ose/files/patch-src-VBox-Main-src-server-freebsd-NetIf-freebsd.cpp
--- virtualbox-ose.orig/files/patch-src-VBox-Main-src-server-freebsd-NetIf-freebsd.cpp 2013-10-20 15:25:06.000000000 +0400
+++ virtualbox-ose/files/patch-src-VBox-Main-src-server-freebsd-NetIf-freebsd.cpp 2013-11-17 04:19:25.000000000 +0400
@@ -1,6 +1,14 @@
---- src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp.orig 2013-08-21 19:50:43.071410350 +0400
-+++ src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp 2013-08-21 19:50:52.448411716 +0400
-@@ -388,7 +388,7 @@
+--- src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp.orig 2013-11-17 04:18:43.000000000 +0400
++++ src/VBox/Main/src-server/freebsd/NetIf-freebsd.cpp 2013-11-17 04:18:22.000000000 +0400
+@@ -46,6 +46,7 @@
+ #include <stdio.h>
+ #include <unistd.h>
+ #include <errno.h>
++#include <stdlib.h>
+
+ #include <list>
+
+@@ -388,7 +389,7 @@
pInfo->Uuid = uuid;
struct ifreq IfReq;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311170020.rAH0KDYH009434>