Date: Sun, 20 Jun 2010 23:45:13 -0700 From: Neel Natu <neelnatu@gmail.com> To: Juli Mallett <jmallett@freebsd.org> Cc: Alan Cox <alc@cs.rice.edu>, freebsd-mips@freebsd.org Subject: Re: Merging 64 bit changes to -HEAD - part 2 Message-ID: <AANLkTinC3laPQiDD7sxtMuUSvBL1_eKKbAYlI8vRLSY6@mail.gmail.com> In-Reply-To: <AANLkTil9mqyeWkSUzasZqwfZL4hmeIq-29FXVddc4Q33@mail.gmail.com> References: <20100617.100235.195066307596264499.imp@bsdimp.com> <AANLkTimkF47RlysFOrma0YhWNDw2w5Lcp9SB1bBoPuxW@mail.gmail.com> <4B66E1A4-E2A5-471F-9FA4-38B506797272@lakerest.net> <20100617.110504.200754750200158040.imp@bsdimp.com> <763BEBBB-B85A-44CE-BFEE-0BADEFF3C185@lakerest.net> <AANLkTikpOaSmTYVfqavtz8T4vZoHWc2CtXIy4SbLlGje@mail.gmail.com> <AANLkTimFjAoXuA-QDwXAOJ0mXK0okIME9SF3841T49zj@mail.gmail.com> <AANLkTil9mqyeWkSUzasZqwfZL4hmeIq-29FXVddc4Q33@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Juli, On Sat, Jun 19, 2010 at 3:18 AM, Juli Mallett <jmallett@freebsd.org> wrote: > On Fri, Jun 18, 2010 at 12:41, Neel Natu <neelnatu@gmail.com> wrote: >> Hi JC, >> >> But what you really want here is to eliminate the intr_disable() and >> intr_restore() and keep sched_pin() and =A0sched_unpin(). > > Are you sure? =A0I'm not. =A0By disabling interrupts we only have to > ensure that the fault path on any address we might access within those > routines doesn't need to use the large memory map. =A0This isn't > trivial, but I think we can acquire a reasonable confidence about it. > If we merely pin, we have to ensure that nothing else that can run > (including interrupts and threads that run via preemption) that would > access the large memory map =97 given that this includes routines like > pmap_zero_page, I think there's good reason for caution. =A0Disabling > interrupts is more conservative, but I think rightly-so. =A0I may be > mistaken. > Duh. You are right, of course. Sorry for the noise. best Neel > Thanks, > Juli. >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTinC3laPQiDD7sxtMuUSvBL1_eKKbAYlI8vRLSY6>