Date: Tue, 16 Jun 2015 02:32:15 +0000 From: "rodrigc (Craig Rodrigues)" <phabric-noreply@FreeBSD.org> To: freebsd-toolchain@freebsd.org Subject: [Differential] [Commented On] D2690: In ypbind, eliminate error: dereferencing type-punned pointer will break strict-aliasing rules Message-ID: <47a2d9357ae3f76473680554ee131777@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-5wjobtbl22co3qb2erjl-req@FreeBSD.org> References: <differential-rev-PHID-DREV-5wjobtbl22co3qb2erjl-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
rodrigc added a comment. Sorry for the late response. Please address @dim 's comment, if you have not addressed it already. Also, removing the type-alias punned warnings is trickier than the other types of fixes that we have done to clean up the code. For this change, I would feel more comfortable if we actually tested ypbind with this code change. I know, this is a headcahe. :( But still, we have to do the right thing. Regarding importing ypbind from OpenBSD. I think this is a good idea, because it looks like they more actively maintain the code. However, this code in FreeBSD is *old*....almost 17 years old. Even if we import from OpenBSD, I don't know if there are changes to functionality, command-line options, etc. that will be introduced. This will require testing also. It depends on how much interest you have in ypbind. :) I don't have a lot of interest, and was just looking at doing minimal code changes to fix compiler warnings. Let me know what approach you want to take. I will support you. REPOSITORY rS FreeBSD src repository REVISION DETAIL https://reviews.freebsd.org/D2690 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: rodrigc, bapt, emaste, dim, araujo Cc: imp, freebsd-toolchain-list
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?47a2d9357ae3f76473680554ee131777>