Date: Thu, 17 Feb 2000 12:20:02 -0800 (PST) From: David Malone <dwmalone@maths.tcd.ie> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/16564: SLIOCSUNIT is broken and can cause panic. Message-ID: <200002172020.MAA54951@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/16564; it has been noted by GNATS. From: David Malone <dwmalone@maths.tcd.ie> To: Ruslan Ermilov <ru@FreeBSD.ORG> Cc: FreeBSD-gnats-submit@FreeBSD.ORG, ache@FreeBSD.ORG, bde@FreeBSD.ORG Subject: Re: kern/16564: SLIOCSUNIT is broken and can cause panic. Date: Thu, 17 Feb 2000 20:17:41 +0000 > > 3) Make SLIOCSUNIT do the equivelent of a slclose(original > > unit) and then a slopen(desired unit), so you are sure > > everything is correctly initialised. This is a relatively > > clean option but means you no longer swap the contents of > > the softc's. It would also remove some of the workaround > > code added for sc.sc_if. > > > I like 3), but I'm not sure it is so simple. I think it would be (relatively) easy to factor the apropriate bits of slclose and slopen into internal functions and use them, but after 4.0 is released. It might make sense to make the sl driver dynamically expandable at the same time, I guess the tun driver could act as a model for this? > Could you please try the attached patch? Seems to work fine here, and I think it makes sense (though as a continuation of a workaround rather than a proper fix). David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200002172020.MAA54951>