Date: Wed, 9 Dec 2015 11:01:33 -0600 From: Eric van Gyzen <vangyzen@FreeBSD.org> To: Hajimu UMEMOTO <ume@FreeBSD.org>, Bruce Evans <brde@optusnet.com.au> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291994 - head/include Message-ID: <56685E6D.5020403@FreeBSD.org> In-Reply-To: <ygefuzb4lpb.wl-ume@FreeBSD.org> References: <201512081609.tB8G9mfd053070@repo.freebsd.org> <yge1tawwei9.wl-ume@FreeBSD.org> <20151209173008.A828@besplex.bde.org> <ygefuzb4lpb.wl-ume@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/09/2015 10:43, Hajimu UMEMOTO wrote: > Hi, > >>>>>> On Wed, 9 Dec 2015 18:19:16 +1100 (EST) >>>>>> Bruce Evans <brde@optusnet.com.au> said: > > brde> resolv.h already had massinve namespace pollution and style bugs in > brde> its includes. One more include of a header that is relatively clean > brde> since it is tiny and was designed for minimising namespace pollution > brde> makes little difference. > > I understood. Thank you for your detailed explanation. > However, I realized that r289315 changed the size of struct > __res_state. It broke binary backward compatibility. I think we > still need to revert its change in struct __res_state and move them > into struct __res_state_ext. Thank you both for your input. I agree with moving the fields. https://reviews.freebsd.org/D4472 Eric
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56685E6D.5020403>