Date: Thu, 17 Dec 1998 21:42:46 +0000 (GMT) From: Doug Rabson <dfr@nlsystems.com> To: Mike Smith <mike@smith.net.au> Cc: Paul van der Zwan <paulz@trantor.stuyts.nl>, current@FreeBSD.ORG Subject: Re: Weird NFS error using Solaris 7 server Message-ID: <Pine.BSF.4.01.9812172140020.55097-100000@herring.nlsystems.com> In-Reply-To: <Pine.BSF.4.01.9812171130540.55097-100000@herring.nlsystems.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 17 Dec 1998, Doug Rabson wrote: > .... One strange effect on a FreeBSD server (with or without this > patch) is that the modtime of testfile1 is set to -1. I'll look into > that later. It turns out that there is a minor problem with ufs_setattr(). The setting of atime and mtime is confused (this appeared in revision 1.91 I think). Index: ufs_vnops.c =================================================================== RCS file: /home/ncvs/src/sys/ufs/ufs/ufs_vnops.c,v retrieving revision 1.101 diff -u -r1.101 ufs_vnops.c --- ufs_vnops.c 1998/12/09 02:06:27 1.101 +++ ufs_vnops.c 1998/12/17 21:41:52 @@ -506,9 +506,9 @@ if (vap->va_mtime.tv_sec != VNOVAL) ip->i_flag |= IN_CHANGE | IN_UPDATE; ufs_itimes(vp); - if (vap->va_mtime.tv_sec != VNOVAL) - ip->i_atime = vap->va_atime.tv_sec; if (vap->va_atime.tv_sec != VNOVAL) + ip->i_atime = vap->va_atime.tv_sec; + if (vap->va_mtime.tv_sec != VNOVAL) ip->i_mtime = vap->va_mtime.tv_sec; error = UFS_UPDATE(vp, (struct timeval *)0, (struct timeval *)0, 0); -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.01.9812172140020.55097-100000>