Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 1 Jan 2007 12:41:09 +0100
From:      Ulrich Spoerlein <uspoerlein@gmail.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        itetcu@FreeBSD.org
Subject:   ports/107393: [PATCH] misc/tinderbox: Unbreak BATCH OPTIONS handling
Message-ID:  <20070101114109.GA46689@roadrunner.q.local>
Resent-Message-ID: <200701011150.l01BoGFr055793@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         107393
>Category:       ports
>Synopsis:       [PATCH] misc/tinderbox: Unbreak BATCH OPTIONS handling
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jan 01 11:50:16 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Ulrich Spoerlein
>Release:        FreeBSD 6.2-PRERELEASE i386
>Organization:
>Environment:
System: FreeBSD roadrunner.q.local 6.2-PRERELEASE FreeBSD 6.2-PRERELEASE #3: Fri Dec 29 20:43:07 CET 2006
>Description:
The OPTIONS framework is flawed wrt. to BATCH mode. There are around 600
instances where wrong checks are performed. For a general fix see ports/105147

This is the same problem as
http://www.freebsd.org/cgi/query-pr.cgi?pr=107349

Port maintainer (itetcu@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
% cd /usr/ports/misc/tinderbox
% make __MAKE_CONF=/dev/null -DBATCH -DWITH_PGSQL -DWITHOUT_MYSQL 
===>  tinderbox-2.3.4_2 is useless without a database. Please (re)run 'make config' and choose one of PGSQL and MYSQL.
*** Error code 1

>Fix:

--- tinderbox-2.3.4_2.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/misc/tinderbox/Makefile,v
retrieving revision 1.26
diff -u -p -u -r1.26 Makefile
--- Makefile	17 Dec 2006 19:07:47 -0000	1.26
+++ Makefile	30 Dec 2006 17:48:11 -0000
@@ -31,7 +31,7 @@ MAN1=		tc-configCcache.1 tc-configDistfi
 
 .include <bsd.port.pre.mk>
 
-.if defined(WITHOUT_PGSQL) && defined(WITHOUT_MYSQL)
+.if !defined(WITH_PGSQL) && defined(WITHOUT_MYSQL)
 IGNORE=	is useless without a database. Please (re)run 'make config' and choose one of PGSQL and MYSQL
 .endif
 
--- tinderbox-2.3.4_2.patch ends here ---

The pre-everything:: target already has this right.
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070101114109.GA46689>