Date: Tue, 10 Jul 2007 17:10:47 +0400 From: "Yuriy Tsibizov" <Yuriy.Tsibizov@gfk.com> To: "Alexander Leidinger" <Alexander@Leidinger.net>, "Christopher Davis" <loafier@FreeBSD.org> Cc: freebsd-hackers@FreeBSD.org, multimedia@FreeBSD.org Subject: RE: Audio driver template Message-ID: <78664C02FF341B4FAC63E561846E3BCC0A145E@ex.hhp.local> In-Reply-To: <20070710093829.34mqbekao4wwww4s@webmail.leidinger.net> References: <c44ca55f0707091147n48741250h588a1fcf59d1b74b@mail.gmail.com> <20070710093829.34mqbekao4wwww4s@webmail.leidinger.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> > http://people.freebsd.org/~cg/template.c > > > > Thought I would take a look at the audio driver template as > > part of my task to modernize drivers, soc2007. I would simplify > > the read and write functions to avoid using the bus tag and > > handle, but I'm not sure what else to do to bring it up to date. > > > > How else can it be improved? >=20 > And you should clarify what kind of improvements are valid for your =20 > SoC work. Somehow I doubt that adding shiny new features (like hps =20 > suggested) is part of the goal for your work. I think it's more like =20 > bringing existing drivers up-to-par with currently available generic =20 > driver interfaces, isn't it? >=20 > I also think examples for suspend/resume stuff should be added. =20 > /sys/dev/sound/pci/atiixp.c has suspend and resume methods if=20 > you want =20 > an example. >=20 > You could also review the locking, as it changed a little bit =20 > recently, I think. >=20 > Apart from the atiixp driver the envy42, emu10kx and HDA drivers can =20 > also serve as examples for what is the most current in the sound =20 > subsystem in FreeBSD. Maybe you can gain some more hints from=20 > them (I =20 > think the template is not very up-to-date compared to them). emu10kx is bad example, because it uses a lot of "hacks", like=20 ac97 codec emulation. Yuriy.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?78664C02FF341B4FAC63E561846E3BCC0A145E>