Date: Sat, 16 Aug 2008 12:10:04 GMT From: Gavin Atkinson <gavin@FreeBSD.org> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/116538: [fdc] [patch] reintroduce FD_NO_CHLINE flag for fdc(4) Message-ID: <200808161210.m7GCA4uh055431@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/116538; it has been noted by GNATS.
From: Gavin Atkinson <gavin@FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc: Eugene Grosbein <eugen@grosbein.pp.ru>
Subject: Re: kern/116538: [fdc] [patch] reintroduce FD_NO_CHLINE flag for
fdc(4)
Date: Sat, 16 Aug 2008 13:08:04 +0100 (BST)
Can you try this patch please?
Index: src/sys/dev/fdc/fdc.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/fdc/fdc.c,v
retrieving revision 1.320
diff -u -r1.320 fdc.c
--- src/sys/dev/fdc/fdc.c 11 Jan 2008 16:50:52 -0000 1.320
+++ src/sys/dev/fdc/fdc.c 16 Aug 2008 12:02:13 -0000
@@ -97,6 +97,8 @@
* fd_drivetype; on i386 machines, if
* given as 0, use RTC type for fd0
* and fd1 */
+#define FD_NO_CHLINE 0x10 /* drive does not support changeline
+ * aka. unit attention */
#define FD_NO_PROBE 0x20 /* don't probe drive (seek test), just
* assume it is there */
@@ -837,7 +839,8 @@
if (bp->bio_cmd & BIO_PROBE) {
- if (!(fdin_rd(fdc) & FDI_DCHG) && !(fd->flags & FD_EMPTY))
+ if (!(device_get_flags(fd->dev) & FD_NO_CHLINE) &&
+ !(fdin_rd(fdc) & FDI_DCHG) && !(fd->flags & FD_EMPTY))
return (fdc_biodone(fdc, 0));
/*
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200808161210.m7GCA4uh055431>