Date: Fri, 21 Nov 2008 10:01:41 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no> To: Joseph Koshy <jkoshy@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r184994 - head/sys/dev/hwpmc Message-ID: <863ahlpi4q.fsf@ds4.des.no> In-Reply-To: <200811151111.mAFBBWnf019276@svn.freebsd.org> (Joseph Koshy's message of "Sat, 15 Nov 2008 11:11:32 %2B0000 (UTC)") References: <200811151111.mAFBBWnf019276@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Joseph Koshy <jkoshy@FreeBSD.org> writes: > Modified: head/sys/dev/hwpmc/hwpmc_mod.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/hwpmc/hwpmc_mod.c Sat Nov 15 11:07:54 2008 (r184993) > +++ head/sys/dev/hwpmc/hwpmc_mod.c Sat Nov 15 11:11:32 2008 (r184994) > @@ -4656,6 +4656,9 @@ pmc_cleanup(void) > if (md->pmd_pcpu_fini) > md->pmd_pcpu_fini(cpu); > } > + > + pmc_md_finalize(md); > + > free(md, M_PMC); > md =3D NULL; > pmc_restore_cpu_binding(&pb); This breaks the ia64, powerpc and sparc64 builds; pmc_md_finalize() is only defined for i386 and amd64. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?863ahlpi4q.fsf>