Date: Sat, 6 Aug 2011 14:41:28 -0700 From: Garrett Cooper <yanegomi@gmail.com> To: Ruslan Mahmatkhanov <cvs-src@yandex.ru> Cc: svn-src-head@freebsd.org, Marius Strobl <marius@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org Subject: Re: svn commit: r224683 - head/lib/libthread_db Message-ID: <CAGH67wSFRXLRBVcoR8RME111pE7UaZ%2By-k8qmTtCkOy%2BMC3Dhw@mail.gmail.com> In-Reply-To: <4E3DA560.6020100@yandex.ru> References: <201108061748.p76HmUbM061259@svn.freebsd.org> <4E3DA560.6020100@yandex.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 6, 2011 at 1:34 PM, Ruslan Mahmatkhanov <cvs-src@yandex.ru> wro= te: > Marius Strobl wrote on 06.08.2011 21:48: >> >> Author: marius >> Date: Sat Aug =A06 17:48:30 2011 >> New Revision: 224683 >> URL: http://svn.freebsd.org/changeset/base/224683 >> >> Log: >> =A0 The tid member of struct pthread actually is long so read it as such= . >> =A0 Accessing it as an int causes failure on big-endian LP64, i.e. mips6= 4be, >> =A0 powerpc64 and sparc64. >> >> =A0 Reviewed by: marcel >> =A0 Approved by: re (kib) >> =A0 MFC after: =A0 1 week >> >> Modified: >> =A0 head/lib/libthread_db/libthr_db.c >> > > Hi. > Seems like this or related libthread_db commit breaks the build on i386: > > =3D=3D=3D> lib/libthr (all) > =3D=3D=3D> lib/libthread_db (all) > cc -O2 -pipe =A0-I. -I/usr/src/lib/libthread_db -std=3Dgnu99 -fstack-prot= ector > -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type > -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter > -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decl= s > -Wold-style-definition -Wno-pointer-sign -c > /usr/src/lib/libthread_db/thread_db.c > cc -O2 -pipe =A0-I. -I/usr/src/lib/libthread_db -std=3Dgnu99 -fstack-prot= ector > -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type > -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter > -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decl= s > -Wold-style-definition -Wno-pointer-sign -c > /usr/src/lib/libthread_db/arch/i386/libpthread_md.c > cc -O2 -pipe =A0-I. -I/usr/src/lib/libthread_db -std=3Dgnu99 -fstack-prot= ector > -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type > -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter > -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decl= s > -Wold-style-definition -Wno-pointer-sign -c > /usr/src/lib/libthread_db/libpthread_db.c > cc -O2 -pipe =A0-I. -I/usr/src/lib/libthread_db -std=3Dgnu99 -fstack-prot= ector > -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter > -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type > -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter > -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decl= s > -Wold-style-definition -Wno-pointer-sign -c > /usr/src/lib/libthread_db/libthr_db.c > cc1: warnings being treated as errors > /usr/src/lib/libthread_db/libthr_db.c: In function 'pt_ta_map_id2thr': > /usr/src/lib/libthread_db/libthr_db.c:217: warning: passing argument 3 of > 'thr_pread_long' from incompatible pointer type > /usr/src/lib/libthread_db/libthr_db.c: In function 'pt_ta_thr_iter': > /usr/src/lib/libthread_db/libthr_db.c:257: warning: passing argument 3 of > 'thr_pread_long' from incompatible pointer type > /usr/src/lib/libthread_db/libthr_db.c: In function 'pt_ta_event_getmsg': > /usr/src/lib/libthread_db/libthr_db.c:398: warning: passing argument 3 of > 'thr_pread_long' from incompatible pointer type > /usr/src/lib/libthread_db/libthr_db.c: In function 'pt_thr_event_getmsg': > /usr/src/lib/libthread_db/libthr_db.c:702: warning: passing argument 3 of > 'thr_pread_long' from incompatible pointer type It's not just i386. It's other architectures like arm, mips, and pc98 according to the tinderbox reports (this list is potentially incomplete). -Garett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGH67wSFRXLRBVcoR8RME111pE7UaZ%2By-k8qmTtCkOy%2BMC3Dhw>