Date: Sun, 20 Aug 2006 08:06:37 +0400 From: Yar Tikhiy <yar@comp.chem.msu.su> To: Garance A Drosehn <gad@FreeBSD.org> Cc: Brooks Davis <brooks@one-eyed-alien.net>, Dag-Erling Sm?rgrav <des@des.no>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: moving pgrep and pkill Message-ID: <20060820040636.GA32859@comp.chem.msu.su> In-Reply-To: <p06230912c10d2672a534@[128.113.24.47]> References: <200608181210.k7ICAIme084410@repoman.freebsd.org> <86ejvet9m6.fsf@xps.des.no> <20060818143310.GA14203@comp.chem.msu.su> <20060818143508.GA2545@lor.one-eyed-alien.net> <20060818153744.GA14726@comp.chem.msu.su> <20060818154240.GA3050@lor.one-eyed-alien.net> <20060819083245.GA23574@comp.chem.msu.su> <p06230912c10d2672a534@[128.113.24.47]>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 19, 2006 at 04:48:51PM -0400, Garance A Drosehn wrote: > At 12:32 PM +0400 8/19/06, Yar Tikhiy wrote: > >On Fri, Aug 18, 2006, Brooks Davis wrote: > > > On Fri, Aug 18, 2006, Yar Tikhiy wrote: > > > > On Fri, Aug 18, 2006, Brooks Davis wrote: > > > > > On Fri, Aug 18, 2006, Yar Tikhiy wrote: > > > > > | On Fri, Aug 18, 2006, Dag-Erling Sm?rgrav wrote: > > > > > | > In a commit msg, Yar Tikhiy <yar@FreeBSD.org> writes: > > > > > | > > Log: > > > > > | > > The ps(1) command is unfriendly to scripts by default > > > > > | > > because it limits the width of its output to the value > > > > > | > > of $COLUMNS, or what TIOCGWINSZ reports, or 79 columns. > > > > > | > > We should specify -ww to ps(1) so that it removes the > > > > > | > > limit and prints lines in full. Otherwise very long > > > > > | > > command pathnames could be mishandled, e.g., > > > > > | > > by _find_processes(). > > > > > | > > > > > > | > or perhaps _find_processes() should use pgrep(1) instead > > > > > | > of ps(1). > > > > > | > > > > > | I considered that but had to stick to ps(1) because pgrep > > > > > | was in /usr/bin while ps was in /bin. The use of /usr/bin > > > > > | tools should be very limited in rc.subr(8). OTOH, pgrep > > > > > | uses /lib libs only, which makes it possible to transfer > > > > > | pgrep+pkill to /bin if we can stand the growth of / by > > > > > | some 50 kbytes. > > > > > > > > > > I think that's appropriate since pgrep is such an obvious > > > > > fit for this sort of thing. I think we'll want to consider > > > > > compatability symlinks due to existing hardcoded paths in > > > > > scripts. > > > I do not mind if `pgrep' and `pkill' are moved to /bin. Note > that these were added to /usr because that's where they exist > on NetBSD, OpenBSD, Solaris and Linux. So we're not just > talking about hardcoded-paths in a few scripts that FreeBSD > users might have written for use only on FreeBSD. So, I expect > we will want symlinks to remain in /usr, forever, if we move > the programs to /bin. > > (Moving them does seem reasonable to me. I'm just saying why > they were put in /usr in the first place...) Thank you! I'll add a comment to src/usr.bin/pkill/Makefile so that the SYMLINKS lines aren't removed without thorough consideration. -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060820040636.GA32859>