Date: Sat, 13 Aug 2005 16:01:50 +0400 From: Andrey Chernov <ache@FreeBSD.ORG> To: "Tim J. Robbins" <tjr@FreeBSD.ORG> Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/lib/libc/regex regex2.h Message-ID: <20050813120150.GA33192@nagual.pp.ru> In-Reply-To: <200508130230.j7D2UGSp002570@repoman.freebsd.org> References: <200508130230.j7D2UGSp002570@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Aug 13, 2005 at 02:30:16AM +0000, Tim J. Robbins wrote: > tjr 2005-08-13 02:30:16 UTC > > FreeBSD src repository > > Modified files: > lib/libc/regex regex2.h > Log: > Change OUT from -2 to CHAR_MIN-1, making it impossible for it to > inadvertently match a negative char in the RE being compiled. It seems this commit may mask the bug where signed comparison used. Better fix perhaps to make compared char unsigned in all places, i.e. if (-2 == (unsigned char)'\254') -- http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050813120150.GA33192>