Date: Tue, 6 Jul 2004 22:41:02 +0800 From: Xin LI <delphij@frontfree.net> To: Dag-Erling Sm?rgrav <des@des.no> Cc: doc@FreeBSD.org Subject: About rules on style changes [Was: Re: Preliminary sys/netinet style patch] Message-ID: <20040706144102.GA4034@frontfree.net> In-Reply-To: <xzpn02d9wxh.fsf@dwp.des.no> References: <20040625033718.GA1691@frontfree.net> <xzpn02d9wxh.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--wRRV7LY7NUeQGEoC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, Dag-Erling, (I have removed freebsd-net@ from cc list and added doc@ as the topic seemed to be more related to doc@) On Tue, Jul 06, 2004 at 01:50:34PM +0200, Dag-Erling Sm?rgrav wrote: > Xin LI <delphij@frontfree.net> writes: > > I have a patchset to remove tailing spaces, convert leading spaces > > to tabs, and removes spaces before tabs. >=20 > As a rule, we never do this except in conjunction with other changes. Hmm... Seems that I have misunderstood the committers' guide, section 10.3, which said: "Do not mix style fixes with new functionality. A style fix is any change which does not modify the functionality of the code. Mixing the changes obfuscates the functionality change when using cvs diff, which can hide any new bugs." I thought that this is not a strict discourage of style fixes. Shall we add something to clarify the rule, like this: "In order to prevent difficulties other committers will encounter when making changes or merging changes from third party, it is discouraged to do style changes when there is no functional changes over a subsystem, and please follow style(9) when committing new code, as a consistent style will ease others' work when merging your changes." Thanks. Cheers, --=20 Xin LI <delphij frontfree net> http://www.delphij.net/ See complete headers for GPG key and other information. --wRRV7LY7NUeQGEoC Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFA6rn+OfuToMruuMARAl+tAJwMRH92KFtSIOxXvYcvV8303naXbwCePMeo PTpr1778jc1P7/93X/2ht/k= =x0kj -----END PGP SIGNATURE----- --wRRV7LY7NUeQGEoC--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040706144102.GA4034>