Date: Tue, 4 Dec 2012 10:09:53 -0800 From: David O'Brien <obrien@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r308256 - in head/misc/figlet: . files Message-ID: <20121204180953.GJ3960@dragon.NUXI.org> In-Reply-To: <CAF6rxg=_MRSQr7Us1J5NeGd=8C8s6U09Xoy9ARw0g6N0yejL9Q@mail.gmail.com> References: <201212041734.qB4HYC4A045663@svn.freebsd.org> <CAF6rxg=_MRSQr7Us1J5NeGd=8C8s6U09Xoy9ARw0g6N0yejL9Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 04, 2012 at 12:44:04PM -0500, Eitan Adler wrote: > On 4 December 2012 12:34, David E. O'Brien <obrien@freebsd.org> wrote: > > Author: obrien > > Date: Tue Dec 4 17:34:12 2012 > > New Revision: 308256 > > URL: http://svnweb.freebsd.org/changeset/ports/308256 > > > > Log: > > Run the tests to ensure a good build. > > Other ports use test: or regression-test: for this. Can we use the same? I want the always tests to run so we know if we have a bad build. I would think we should always do this as otherwise the tests will likely seldom get run. I could change it to: -post-build: +regression-test: @ cd ${WRKSRC} && ${MAKE} check +post-build test: regression-test so that these targets exist for manual running. I actually like that, so I'll commit this patch and we can continue talking about the 'post-build' usage. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121204180953.GJ3960>