Date: Tue, 29 Jun 2010 16:58:50 GMT From: "Joseph S. Atkinson" <jsa@wickedmachine.net> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/148235: Supress noisy, always fail test condition in devel/xdg-utils Message-ID: <201006291658.o5TGwoTb028179@www.freebsd.org> Resent-Message-ID: <201006291700.o5TH0LgK062087@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 148235 >Category: misc >Synopsis: Supress noisy, always fail test condition in devel/xdg-utils >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jun 29 17:00:20 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Joseph S. Atkinson >Release: >Organization: >Environment: >Description: xdg-screensaver performs a check for `mv -T` to safely move lockfiles to /tmp. FreeBSD does not support the -T switch, which causes mv to complain and spit out a usage example. If an app is run from the console (such as vlc), when calls to xdg-screensaver are made, it spews this error information to the terminal, possibly leading the user to believe the application is attempting to misappropriately move their data. >How-To-Repeat: Run multimedia/vlc from a terminal, opening any video multimedia type. Watch for scary message that the app failed to `mv` something... >Fix: This patch (which should just be inserted into ${FILESDIR}) comments out the offending test condition and replaces it with the `false` command to essentially skip to the else condition without noisy error messages. IMPORTANT: You must remove the .txt extension required by web based pr interface. Patch attached with submission follows: --- ./scripts/xdg-screensaver.orig 2010-06-29 12:36:04.000000000 -0400 +++ ./scripts/xdg-screensaver 2010-06-29 12:37:22.000000000 -0400 @@ -355,7 +355,9 @@ } # Check if we can use "mv -T" -if mv -T ... ... 2>&1 | grep '\.\.\.' > /dev/null ; then +# FreeBSD cannot, so supress scary messages in the terminal +#if mv -T ... ... 2>&1 | grep '\.\.\.' > /dev/null ; then +if false ; then # We can securely move files in /tmp with mv -T DEBUG 1 "mv -T available" MV="mv -T" >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006291658.o5TGwoTb028179>