Date: Tue, 4 Sep 2012 07:31:33 -0600 From: Warner Losh <imp@bsdimp.com> To: Oleksandr Tymoshenko <gonzo@freebsd.org> Cc: "arch@freebsd.org" <arch@freebsd.org>, mav@freebsd.org Subject: Re: [RFC] SDHCI driver split Message-ID: <C7774C42-535E-4D35-9EE5-47344E46F315@bsdimp.com> In-Reply-To: <A4D4F17C-59C1-4DD0-94D0-AED021E265E8@freebsd.org> References: <A4D4F17C-59C1-4DD0-94D0-AED021E265E8@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sep 3, 2012, at 10:03 PM, Oleksandr Tymoshenko wrote: > Hello, > > Proposed patch[1] splits sdhci driver in two parts: reusable SDHCI > logic and PCI driver that provides access to registers. > > I tested it on X220 with Ricoh controller - no performance regression: > reading 4Gb card takes 180 seconds (+/- 2) for both versions, old and new. > > If there are no objections - I'll commit it later this week. > > [1] http://people.freebsd.org/~gonzo/patches/sdhci-pci-3.diff I don't see anything overtly broken in this patch. Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C7774C42-535E-4D35-9EE5-47344E46F315>