Date: Thu, 12 Feb 2004 02:26:43 -0800 From: Kris Kennaway <kris@obsecurity.org> To: Dag-Erling Sm?rgrav <des@des.no> Cc: Trevor Johnson <trevor@jpj.net> Subject: Re: cvs commit: ports/www/firefox Makefile distinfo pkg-descr pkg-message pkg-plist ports/www/firefox/files firebird.rb firefox.rb mkdistfile mozconfig.in patch-Double.cpp patch-build_unix_run-mozilla Message-ID: <20040212102643.GA63287@xor.obsecurity.org> In-Reply-To: <xzplln8k3fp.fsf@dwp.des.no> References: <200402110716.i1B7GH9D017803@repoman.freebsd.org> <xzpisidbtvn.fsf@dwp.des.no> <1076508074.88428.14.camel@pav.hide.vol.cz> <20040211122704.X93022@blues.jpj.net> <xzpk72tiah1.fsf@dwp.des.no> <20040211165940.Q98525@blues.jpj.net> <xzp4qtweqlf.fsf@dwp.des.no> <20040212031228.E31447@blues.jpj.net> <xzplln8k3fp.fsf@dwp.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--Dxnq1zWXvFF0Q93v
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Feb 12, 2004 at 11:16:58AM +0100, Dag-Erling Sm?rgrav wrote:
> Trevor Johnson <trevor@jpj.net> writes:
> > > The "added dependency" argument is specious as it is only true for
> > > RELENG_4_6 and earlier.
> > grep OSVERSION /usr/ports/Mk/bsd.port.mk
>=20
> what exactly are you trying to prove?
>=20
> .if defined(USE_REINPLACE)
> REINPLACE_ARGS?=3D -i.bak
> .if ${OSVERSION} < 460101 || ( ${OSVERSION} >=3D 500000 && ${OSVERSION} <=
500036 )
> PATCH_DEPENDS+=3D ${LOCALBASE}/bin/sed_inplace:${PORTSDIR}/textproc/sed_i=
nplace
> REINPLACE_CMD?=3D ${LOCALBASE}/bin/sed_inplace ${REINPLACE_ARGS}
> .else
> REINPLACE_CMD?=3D ${SED} ${REINPLACE_ARGS}
> .endif
>=20
> BTW, I don't see why REINPLACE_CMD couldn't simply be ${PERL} -p
> ${REINPLACE_ARGS} on systems that don't have sed -i, since both 4.x
> and 5.x prior to 500036 have Perl in the base system.
AFAIK we used to do this, but perl and sed regexps are not always
interchangeable, and it was a real pain to keep fixing them so they
were.
Kris
--Dxnq1zWXvFF0Q93v
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFAK1TiWry0BWjoQKURAvtoAJ0fr9qGXkid2ph5jQ7XbsaWoyjLPACfSgG8
YTWFbnVt77PJv58VuztSU+M=
=jMh4
-----END PGP SIGNATURE-----
--Dxnq1zWXvFF0Q93v--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040212102643.GA63287>