Date: Tue, 2 Apr 2002 11:22:53 -0800 (PST) From: Julian Elischer <julian@elischer.org> To: Kenneth Culver <culverk@alpha.yumyumyum.org> Cc: Mike Barcroft <mike@FreeBSD.ORG>, Matthew Dillon <dillon@apollo.backplane.com>, "M. Warner Losh" <imp@village.org>, jake@locore.ca, dillon@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/i386 critical.c src/sys/i386/include cpufunc.h critical.h src/sys/i386/isa apic_vector.s icu_vector.s src/sys/kern kern_fork.c kern_proc.c kern_switch.c src/sys/alpha/alph Message-ID: <Pine.BSF.4.21.0204021118220.21569-100000@InterJet.elischer.org> In-Reply-To: <20020402100957.C45652-100000@alpha.yumyumyum.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2 Apr 2002, Kenneth Culver wrote:
> > > if (a) {
> > > x;
> > > y;
> > > } else
> > > /*
> > > * HITHERE!
> > > */
> > > b;
> >
> > This looks better with proper 8 character tabs. I think in KNF extra
> > braces are normally used in situations like this, but this is an edge
> > case.
>
> 8 character tabs? why use tabs at all? That requires an
> engineer/programmer to set that in an editor, and a lot of people don't
> like having tabs that are that large... I just use spaces because then my
> code will look the same as when I wrote it no matter what editor is used,
> and no matter what the tabs are set to.
Then your code would be different from all other code in FreeBSD.
Code checeked in should be 8 character tabs.. this is one of the most
BASIC requirements, even if some developers feel themselves too important
to abide by it.. It is one of the first things that gives the BSD
code base a unified appearance.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0204021118220.21569-100000>