Date: Wed, 17 Apr 2013 16:11:10 -0500 From: Brooks Davis <brooks@FreeBSD.org> To: Brooks Davis <brooks@FreeBSD.org>, Jeremy Chadwick <jdc@koitsu.org>, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-stable@FreeBSD.org, svn-src-stable-9@FreeBSD.org Subject: Re: svn commit: r249549 - in stable/9/sys: amd64/conf i386/conf Message-ID: <20130417211110.GA31145@lor.one-eyed-alien.net> In-Reply-To: <20130417210011.GD30222@caravan.chchile.org> References: <201304161609.r3GG9SID009937@svn.freebsd.org> <20130416161919.GA80626@icarus.home.lan> <20130417125433.GC30222@caravan.chchile.org> <20130417193538.GB9331@icarus.home.lan> <20130417194706.GA30583@lor.one-eyed-alien.net> <20130417210011.GD30222@caravan.chchile.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--DocE+STaALJfprDB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Wed, Apr 17, 2013 at 11:00:11PM +0200, Jeremie Le Hen wrote:
> On Wed, Apr 17, 2013 at 02:47:06PM -0500, Brooks Davis wrote:
> >=20
> > > I will spend some time to figure out exactly how to reproduce this.
> > >=20
> > > Going from recent memory (~2 weeks ago), I encountered it on my VPS b=
ox
> > > (which does run ntpd, just FYI):
> > >=20
> > > 1. Initially installed with 9.1-RELEASE,
> > > 2. Upgraded to stable/9 (using svn),
> > > 3. WITHOUT_CDDL=3Dtrue and WITHOUT_ZFS=3Dtrue added to /etc/src.conf
> > > 4. world/kernel rebuilt/reinstalled/etc. (this includes make delete-o=
ld,
> > > as per instructions in src/Makefile -- which would delete
> > > /usr/bin/ctfconvert)
> > > 5. Fast forward many months
> > > 6. Removed WITHOUT_CDDL=3Dtrue from src.conf
> > > 7. Encountered the above issue ("ctfconvert: not found") during
> > > buildkernel
> > > 8. Rebuilt kernel again -- same error
> > > 9. Removed WITHOUT_ZFS=3Dtrue from src.conf
> > > 10. Rebuilt kernel again -- worked
> > >=20
> > > This could mean WITHOUT_ZFS=3Dtrue has some bearing on this situation=
, but
> > > I don't see how/why, as WITHOUT_CDDL is supposed to be the "trigger" =
for
> > > ctf* utilities. I did poke around the Makefiles and framework a bit
> > > but didn't have any epiphanies.
> > >=20
> > > Like I said -- I'll try to reproduce the exact scenario.
> >=20
> > Looking at Makefile.inc1 around line 1164 (on HEAD), ctfconvert and
> > cftmerge are bootstrap tools only when they don't exist at all on the
> > host. The code there should be expanded to bootstrap for cases where
> > the installed ones are known to be broken (virtually all prior versions
> > given recent fixes) as well as when they aren't present on the host
> > system.
>=20
> Do you have an idea how we can identify whether the installed
> ctfconvert(1) is broken or not? I think in Jeremy's case we cannot rely
> on OSRELDATE given that right before he built and installed world with
> WITHOUT_CDDL, so ctfconvert and OSRELDATE are not in sync.
I think we should be able to come up with a fairly reliable set values
where it's broken. We can also add a exists(/usr/bin/ctfconvert) to
catch the case were the user caused it to not be there.
> Why not just always add ctfconvert to bootstrap tools when it is needed?
> I don't know how long it takes to build though, but it is probably
> nothing compared to LLVM ;-).
It's probably not too bad to add, but I don't think it's changing all
that quickly so as long as people remember to update Makefile.inc1 it
shouldn't too bad.
-- Brooks
--DocE+STaALJfprDB
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (FreeBSD)
iD8DBQFRbw/tXY6L6fI4GtQRAgMJAKDGORBqUjaCUN+C7GP1WVqaLNQN8ACgyXl5
x4JVIqBpHCL3OIpwC/AbizE=
=dKfW
-----END PGP SIGNATURE-----
--DocE+STaALJfprDB--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130417211110.GA31145>