Date: Sun, 19 Jun 2016 14:06:56 +0200 (CEST) From: Gerald Pfeifer <gerald@pfeifer.com> To: John Marino <marino@freebsd.org> Cc: Andreas Tobler <andreast@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r416339 - head/lang/gcc5-aux/files Message-ID: <alpine.LSU.2.20.1606191356200.2645@anthias.pfeifer.com> In-Reply-To: <98f0eac7-3559-81fd-29cd-bd234cec6b6b@marino.st> References: <201606032131.u53LV4K3009774@repo.freebsd.org> <98f0eac7-3559-81fd-29cd-bd234cec6b6b@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi John, On Sat, 4 Jun 2016, John Marino wrote: >> Author: andreast (src committer) >> Date: Fri Jun 3 21:31:04 2016 >> New Revision: 416339 >> URL: https://svnweb.freebsd.org/changeset/ports/416339 >> >> Log: >> Skip armv6hf support and move it into armv6. > These aren't going to work. > I don't use regular patches, at all. They can interfere with the generated > diff-* aggregate patches. Any new patch should be pulled into there. > > But what are these patches really for? Ada doesn't build on ARM due to the > lack of a bootstrap compiler and interest. Should we just set ONLY_FOR_ARCH > because without Ada, people should probably use the stock lang/gcc* ports. I believe what happened is that as Andreas and me discussed fixing armv6hf / armv6 support and I approved changes to "my" lang/gcc* ports, he (or some tab completion) unintentionally also hit this lang/gcc5-aux ports. And, I agree, unless someone is looking for Ada, using the stock lang/gcc* ports probably makes most sense. Gerald PS: By the way, how about using the standard FORTRAN instead of FORT in your ports, per the patch below? Index: Makefile =================================================================== --- Makefile (revision 417113) +++ Makefile (working copy) @@ -30,12 +30,11 @@ LDFLAGS+= -L${LOCALBASE}/lib OPTIONS_GROUP= Standard Bootstrap -OPTIONS_GROUP_Standard= FORT OBJC NLS TESTSUITE ALLSTAGES STATIC +OPTIONS_GROUP_Standard= FORTRAN OBJC NLS TESTSUITE ALLSTAGES STATIC OPTIONS_GROUP_Bootstrap=BOOTSTRAP -OPTIONS_DEFAULT= FORT OBJC +OPTIONS_DEFAULT= FORTRAN OBJC NO_OPTIONS_SORT= yes -FORT_DESC= Fortran language support OBJC_DESC= Objective-C language support TESTSUITE_DESC= Activate test support ALLSTAGES_DESC= Build compiler with itself (twice, brings in libcc1) @@ -113,7 +112,7 @@ ada-bootstrap.x86_64.freebsd.100B.tar.bz2:boot .endif -.if ${PORT_OPTIONS:MFORT} && !${PORT_OPTIONS:MBOOTSTRAP} +.if ${PORT_OPTIONS:MFORTRAN} && !${PORT_OPTIONS:MBOOTSTRAP} LANGS+= fortran EXTRA_CONFIG+= --enable-libquadmath .else @@ -238,7 +237,7 @@ ${MAKE_CMD} -j${MAKE_JOBS_NUMBER} -sk check-c test-fortran: -. if ${PORT_OPTIONS:MFORT} +. if ${PORT_OPTIONS:MFORTRAN} cd ${BUILDDIR} && ${SETENV} ${ADA_MAKE_ENV} \ ${MAKE_CMD} -j${MAKE_JOBS_NUMBER} -sk check-fortran . endif
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.LSU.2.20.1606191356200.2645>