Date: Wed, 3 Sep 2014 10:12:39 +0100 From: "Steven Hartland" <smh@freebsd.org> To: "Andriy Gapon" <avg@FreeBSD.org> Cc: src-committers@FreeBSD.org, John Baldwin <jhb@FreeBSD.org>, Peter Wemm <peter@wemm.org>, Alan Cox <alc@rice.edu>, svn-src-all@FreeBSD.org, Dmitry Morozovsky <marck@rinet.ru>, "Matthew D. Fuller" <fullermd@over-yonder.net>, svn-src-head@FreeBSD.org Subject: Re: svn commit: r270759 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys cddl/contrib/opensolaris/uts/common/fs/zfs vm Message-ID: <7DF8E1BCE4E648888B9AA8BABB1A5991@multiplay.co.uk> References: <201408281950.s7SJo90I047213@svn.freebsd.org> <E0F163ECBF5E407F99AFDB18FAB05C58@multiplay.co.uk> <39211177.i8nn9sHiCx@overcee.wemm.org> <201409021201.15967.jhb@freebsd.org> <5405F1F3.1@FreeBSD.org> <8AA1D02BB967468DA07731149E95390D@multiplay.co.uk> <5406D972.8010305@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
----- Original Message ----- From: "Andriy Gapon" <avg@FreeBSD.org> > on 02/09/2014 20:43 Steven Hartland said the following: >> ----- Original Message ----- From: "Andriy Gapon" <avg@FreeBSD.org> >>> And the newly added kmem_foo() functions probably do not belong in >>> cddl/compat/opensolaris as Solaris / illumos does not have those functions. >> >> They could be moved but their current location keeps all the kmem >> related functions neatly in one place. Spreading them around IMO >> would just make things hard to find. > > BTW, here is some of my old WIP that completely removed the pre-existing kmem_* > functions and made the related code much closer to that in illumos. > Unfortunately, I will now have hard time merging my changes with your change. > > https://github.com/avg-I/freebsd/compare/wip/hc/kmem_size-memguard-fix > (esp.commits e0cf2f7 and becf087) Looking good, I'm all for eliminating the differences between the two code bases as that will make things easier to maintain in the future, so something we should definitely try to get in for 11. Regards Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7DF8E1BCE4E648888B9AA8BABB1A5991>