Date: Thu, 2 Feb 2006 12:35:06 +0300 From: Oleg Bulyzhin <oleg@freebsd.org> To: Mihail Balikov <misho@interbgc.com> Cc: cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/dev/bge if_bge.c Message-ID: <20060202093506.GB21235@lath.rinet.ru> In-Reply-To: <004101c627d7$4960f260$08e009d9@misho> References: <200602011441.k11Ef8Gi068735@repoman.freebsd.org> <004101c627d7$4960f260$08e009d9@misho>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Feb 02, 2006 at 11:01:42AM +0200, Mihail Balikov wrote: > in bge_poll_locked() , when you detect link state change, > why don't you call bge_link_upd() immediately, instead of waiting for next > POLL_AND_CHECK ? bge_link_upd() is rather expensive. Some versions of bcm570x chip have semi-broken statusword - they always report link event, so you will get HZ/sec calls of bge_link_upd() (which involves ~6 pci register reads for copper nics). Anyway, you can tweak kern.polling.reg_frac in order to detect link events earlier. > > > ----- Original Message ----- > From: "Oleg Bulyzhin" <oleg@FreeBSD.org> > To: <src-committers@FreeBSD.org>; <cvs-src@FreeBSD.org>; > <cvs-all@FreeBSD.org> > Sent: Wednesday, February 01, 2006 4:41 PM > Subject: cvs commit: src/sys/dev/bge if_bge.c > > > > oleg 2006-02-01 14:41:08 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/bge if_bge.c > > Log: > > Since bge_rxeof() & bge_txeof() depends on status block data it should > be > > synchronized on every call of bge_poll_locked(). > > > > Suggested by: Mihail Balikov <mihail.balikov AT interbgc DOT com> > > Approved by: glebius (mentor) > > MFC after: 3 days > > > > Revision Changes Path > > 1.121 +16 -14 src/sys/dev/bge/if_bge.c > > _______________________________________________ > > cvs-src@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/cvs-src > > To unsubscribe, send any mail to "cvs-src-unsubscribe@freebsd.org" > > > > > > __________ NOD32 1.1390 (20060201) Information __________ > > > > This message was checked by NOD32 antivirus system. > > http://www.eset.com > > > > -- Oleg.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060202093506.GB21235>