Date: Tue, 10 Apr 2007 09:57:29 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Brian Somers <brian@Awfulhak.org> Cc: Greg 'groggy' Lehey <grog@FreeBSD.org>, Dag-Erling Sm??rgrav <des@des.no>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/touch touch.1 touch.c Message-ID: <20070410165729.GH2382@elvis.mu.org> In-Reply-To: <20070410094659.49041afb@conflict.ca.sophos.com> References: <200704090219.l392Jc1f064727@repoman.freebsd.org> <864pnpdf8w.fsf@dwp.des.no> <20070410010901.GD61460@wantadilla.lemis.com> <86zm5gr9wl.fsf@dwp.des.no> <20070410071256.GJ91694@wantadilla.lemis.com> <20070410094659.49041afb@conflict.ca.sophos.com>
next in thread | previous in thread | raw e-mail | index | archive | help
The reason you make it static is so that when you add another file to the build, there is no need to track down what should be static. * Brian Somers <brian@Awfulhak.org> [070410 09:49] wrote: > On Tue, 10 Apr 2007 16:42:56 +0930 > "Greg 'groggy' Lehey" <grog@FreeBSD.org> wrote: > > > On Tuesday, 10 April 2007 at 9:00:42 +0200, Dag-Erling Smrgrav wrote: > > > Greg 'groggy' Lehey <grog@FreeBSD.org> writes: > > >> On Monday, 9 April 2007 at 12:16:47 +0200, Dag-Erling Smrgrav wrote: > > >>> The latter part is incorrect and should be reverted. Furthermore, > > >>> usage() should be static. > > >> Can you give details? > > > > > > usage() should be the way it was before your commit, except that it > > > should be static. > > > > You mean declared as a static function? In a program of a single > > file? > > > > As I said before, > > > > >> Can you give details? > > > > Specifically, this doesn't match my recollection of "good practice". > > Where is this behaviour mandated? > > Bump WARNS? Every function should be either prototyped > or declared static (or both). > > -- > Brian Somers <brian@Awfulhak.org> > Don't _EVER_ lose your sense of humour ! <brian@FreeBSD.org> -- - Alfred Perlstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070410165729.GH2382>