Date: Mon, 19 Nov 2007 22:00:42 GMT From: Rainer Schwarze <rsc@admadic.de> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/118139: [PATCH] port mail/qmail-scanner: Makefile: QS_NOTIFY not correctly passed to configure Message-ID: <200711192200.lAJM0gY2077329@www.freebsd.org> Resent-Message-ID: <200711192210.lAJMA1P6073934@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 118139
>Category: ports
>Synopsis: [PATCH] port mail/qmail-scanner: Makefile: QS_NOTIFY not correctly passed to configure
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Nov 19 22:10:01 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator: Rainer Schwarze
>Release: FreeBSD 6,2-RELEASE i386
>Organization:
admaDIC
>Environment:
FreeBSD <not-shown> 6.2-RELEASE FreeBSD 6.2-RELEASE #0: Fri Jan 12 10:40:27 UTC 2007 root@dessler.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386
>Description:
In port mail/qmail-scanner the Makefile does not correctly append the QS_NOTIFY value to CONFIGURE_ARGS when QS_NOTIFY has been specified with the make call.
When QS_NOTIFY is not specified, the Makefile defaults will be used, when it is specified, the Makefile does not append "--notify ..." to CONFIGURE_ARGS and the defaults of the configure script are used.
For instance, if the notifications should only be sent to the admin ( make QS_NOTIFY=admin ), the result of the build process is as if configure was called with "--notify psender,precips" instead of "--notify admin".
>How-To-Repeat:
Run "make QS_NOTIFY=admin". Run "grep NOTIFY_ADDRS work/qmail-scanner-2.01/qmail-scanner-queue.pl" - the first line will read "my $NOTIFY_ADDRS='psender,nmlvadm'". It should be "my $NOTIFY_ADDRS='admin'"
>Fix:
(See patch file)
After these lines in Makefile:
.if !defined(QS_NOTIFY)
CONFIGURE_ARGS+= --notify psender,precips
.endif
add these lines:
.if defined(QS_NOTIFY)
CONFIGURE_ARGS+= --notify "${QS_NOTIFY}"
.endif
Patch attached with submission follows:
--- /usr/ports/mail/qmail-scanner/Makefile Sat Nov 17 15:14:58 2007
+++ ./Makefile Fri Nov 9 23:24:42 2007
@@ -109,6 +109,10 @@
CONFIGURE_ARGS+= --notify psender,precips
.endif
+.if defined(QS_NOTIFY)
+CONFIGURE_ARGS+= --notify "${QS_NOTIFY}"
+.endif
+
.if defined(QS_LOCALDOMAINS) && !empty(QS_LOCALDOMAINS)
CONFIGURE_ARGS+= --local-domains "${QS_LOCALDOMAINS}"
.endif
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200711192200.lAJM0gY2077329>