Date: Mon, 23 Dec 2013 13:14:50 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Alexander Motin <mav@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r259765 - in head/sys: fs/nfsserver nfs nfsserver Message-ID: <20131223111450.GB59496@kib.kiev.ua> In-Reply-To: <201312230843.rBN8hHTx077901@svn.freebsd.org> References: <201312230843.rBN8hHTx077901@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--tI9MNtoWUQpHAhYF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 23, 2013 at 08:43:17AM +0000, Alexander Motin wrote: > Author: mav > Date: Mon Dec 23 08:43:16 2013 > New Revision: 259765 > URL: http://svnweb.freebsd.org/changeset/base/259765 >=20 > Log: > Fix RPC server threads file handle affinity to work better with ZFS. > =20 > Instead of taking 8 specific bytes of file handle to identify file du= ring > RPC thread affitinity handling, use trivial hash of the full file handl= e. > ZFS's struct zfid_short does not have padding field after the length fi= eld, > as result, originally picked 8 bytes are loosing lower 16 bits of objec= t ID, > causing many false matches and unneeded requests affinity to same threa= d. > This fix substantially improves NFS server latency and scalability in= SPEC > NFS benchmark by more flexible use of multiple NFS threads. > =20 > Sponsored by: iXsystems, Inc. Did you audited all other filesystems to ensure that struct fid. fid_data0 is filled (zeroed) consistently ? Also, this constitues subtle VFS KBI change. --tI9MNtoWUQpHAhYF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSuBspAAoJEJDCuSvBvK1BwMEP+wamI6B68N8YfFdv6dNGtfQC rKefbACswFJqM4XPFtQ/i0GbWXlcyAldlsSnAzw9goqkIq19uumr7q514SCHckQ5 TGdDoIC1GOXsSisbUU6Qjl1wJgDy7YqNn+CFCWI8DYsD65Dq2W+jZMWgNsJoWWA7 j5PLQcyBVuBNeXy+oQnOaBBXtCRDnSct0HVibAUFheWOwR+gerxvGpo2QJAMs7d+ LziMnnZAgbnDdFidYU+DaL4M1QzfYNVT2plcKE0ZObhxdjWT+0qCU+MjzwK7Th3d 5WOGDJsDbHkta1iOzA1bE0n3DuGN102pr2agIHPru9l23p8AuQNAhHyQAb7YZ5Mc p234zWzJksfI/lZ4mV3QH9LutPmKSdsWOC5VpEJ6glK9K3iyiwor5z7twmRr9+7F lxbUtiJF7G7WTxCrFI9vuQiAfPecf7L1Fk5qw1fOpUyEjiCI0wzCzeC0dhwXNoEU XJfamXWgLWnAlskNY6oFcfnL/u47TpVwCzuMOx/54p25XB+/3zSoo2WWF/l4LtvL +wNOwunAYVB3zci5gOM9ZEvo11kJ/LR19mSIQEEWlN6MSqH7Y8AFdhdQM9Lk328F N6T5A+502OKWiMlG9oQZg1zeJ41TKQoUVHcDcj1th6MK0gTwaMhlEeQ+r6VP4uID NNIUreOqK2Y2qpE69Vbe =z3J2 -----END PGP SIGNATURE----- --tI9MNtoWUQpHAhYF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131223111450.GB59496>