Date: Wed, 19 Nov 2014 17:11:14 +0300 From: Anton Yuzhaninov <citrin@citrin.ru> To: svn-src-all@freebsd.org Subject: Re: svn commit: r274710 - head/sbin/ifconfig Message-ID: <546CA502.4020008@citrin.ru> In-Reply-To: <201411191357.sAJDvexm004236@svn.freebsd.org> References: <201411191357.sAJDvexm004236@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/19/14 16:57, Mark Felder wrote: > New Revision: 274710 > URL: https://svnweb.freebsd.org/changeset/base/274710 > > Log: > Expose groups by default in ifconfig output. This was never hidden by > OpenBSD; unsure why we chose to do so. As groups are a requirement for > pf, exposing them by default will make our pf implementation less > confusing. ... > > Modified: head/sbin/ifconfig/ifgroup.c > ============================================================================== > --- head/sbin/ifconfig/ifgroup.c Wed Nov 19 13:31:08 2014 (r274709) > +++ head/sbin/ifconfig/ifgroup.c Wed Nov 19 13:57:39 2014 (r274710) > @@ -86,9 +86,6 @@ getifgroups(int s) > struct ifgroupreq ifgr; > struct ifg_req *ifg; > > - if (!verbose) > - return; Please return groups output under verbose flag. pf is used not by all. And more longer ifconfig output is unhandy. Especially on hosts with many interfaces. Better to document ifconfig -v in pf.conf(5)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?546CA502.4020008>