Date: Sun, 24 Aug 2014 16:44:34 +0200 From: Michael Gmelin <grembo@freebsd.org> To: olli hauer <ohauer@gmx.de>, Kurt Jaeger <lists@opsec.eu>, ports-list freebsd <freebsd-ports@freebsd.org> Cc: Matthias Andree <mandree@FreeBSD.org> Subject: Re: HEADS UP: Berkeley DB 4...4.7 port removals/upgrades may require manual preparation Message-ID: <20140824164434.1bfddfcb@bsd64.grem.de> In-Reply-To: <20140824153618.32060060@bsd64.grem.de> References: <53F640EF.7000200@FreeBSD.org> <20140824102826.GB9400@home.opsec.eu> <EB2B24ED-1D62-467B-8870-EEACA8A72281@freebsd.org> <20140824111149.GD9400@home.opsec.eu> <53F9CEDA.4070309@gmx.de> <20140824142050.5e336477@bsd64.grem.de> <20140824123006.GE9400@home.opsec.eu> <20140824143728.0d5c435b@bsd64.grem.de> <53F9E3B7.10009@gmx.de> <20140824153618.32060060@bsd64.grem.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 24 Aug 2014 15:36:18 +0200
Michael Gmelin <grembo@freebsd.org> wrote:
> On Sun, 24 Aug 2014 15:08:07 +0200
> olli hauer <ohauer@gmx.de> wrote:
>
> > On 2014-08-24 14:37, Michael Gmelin wrote:
> > >
> > >
> > > On Sun, 24 Aug 2014 14:30:06 +0200
> > > Kurt Jaeger <lists@opsec.eu> wrote:
> > >
> > >> Hi!
> > >>
> > >>>> Hm, using USE_BDB=$numble looks wrong to me in devel/ice.
> > >>>>
> > >>>> Can you test the following patch.
> > >>>>
> > >>>> Index: Makefile
> > >>>> ===================================================================
> > >>>> --- devel/ice/Makefile (revision 365910)
> > >>>> +++ devel/ice/Makefile (working copy)
> > >>>> @@ -27,7 +27,8 @@
> > >>>> .endif
> > >>>>
> > >>>> USES= iconv gmake
> > >>>> -USE_BDB= 5
> > >>>> +USE_BDB= yes
> > >>>> +WANT_BDB_VER= 5
> > >>>> INVALID_BDB_VER= 40 41 42 43 44 46 47 48 6
> > >>>> USE_LDCONFIG= yes
> > >>>> BUILD_WRKSRC?= ${WRKSRC}/cpp
> > >>
> > >>> @Kurt: Could you test and confirm? If this works, I'll commit
> > >>> the patch.
> > >>
> > >> Yes, it builds.
> > >>
> > >
> > > I created a commit request
> > >
> > > https://reviews.freebsd.org/D679
> > >
> >
> > Kurt, or you can commit this even w.o. PR.
> > The patch does not break anything but allows the port to build as
> > required. I assume there are even more easter eggs in the tree,
> > specially for USE_BDB.
> >
@Kurt: I assume you have WITH_BDB_VER= 6 in your make.conf?
>
> A short grep shows that the following ports are affected, the question
> is if simply converting them to
>
> USE_BDB= yes
> WANT_BDB_VER= <prior value of USE_BDB>
>
> is the right thing to do.
>
To answer my own question: Probably not, as it seems legal to use
USE_BDB= <version>, which *should* (or at least used to) have the same
effect as
USE_BDB= yes
WITH_BDB_VER= <version>
I'm a bit curious what the correct use of INVALID_BDB_VER is, since it
seems incompatible with using WITH_BDB_VER in make.conf, so in the end
a port always has to specify WANT_BDB_VER if you want to ensure it
builds correctly.
Also, using INVALID_BDB_VER in devel/ice seems redundant now:
USE_BDB= yes
WANT_BDB_VER= 5
INVALID_BDB_VER= 40 41 42 43 44 46 47 48 6
I assume that
USE_BDB= yes
WANT_BDB_VER= 5
will accomplish the same.
- Michael
--
Michael Gmelin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140824164434.1bfddfcb>