Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 23 Mar 2014 17:06:34 -0700 (PDT)
From:      Don Lewis <truckman@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/187883: [patch] readline update broke devel/seed
Message-ID:  <201403240006.s2O06YLZ064514@mousie.catspoiler.org>
Resent-Message-ID: <201403240010.s2O0A0qp090897@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         187883
>Category:       ports
>Synopsis:       [patch] readline update broke devel/seed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Mar 24 00:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Don Lewis
>Release:        FreeBSD 8.4-STABLE i386
>Organization:
FreeBSD Project
>Environment:
System: FreeBSD scratch.catspoiler.org 8.4-STABLE FreeBSD 8.4-STABLE #70 r263289: Tue Mar 18 13:22:31 PDT 2014     dl@scratch.catspoiler.org:/usr/obj/usr/src/sys/GENERICDDB  i386

	seed-2.31.91_3
	readline-6.3_1


>Description:

	The upgrade to readline-6.3 removed a deprecated typedef that
	seed was relying on.

Making all in readline
gmake[3]: Entering directory `/usr/ports/devel/seed/work/seed-2.31.91/modules/readline'
  CC     libseed_readline_la-seed-readline.lo
seed-readline.c: In function 'seed_readline_bind':
seed-readline.c:80: error: 'Function' undeclared (first use in this function)
seed-readline.c:80: error: (Each undeclared identifier is reported only once
seed-readline.c:80: error: for each function it appears in.)
seed-readline.c:80: error: expected expression before ')' token
gmake[3]: *** [libseed_readline_la-seed-readline.lo] Error 1
gmake[3]: Leaving directory `/usr/ports/devel/seed/work/seed-2.31.91/modules/readline'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/devel/seed/work/seed-2.31.91/modules'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/usr/ports/devel/seed/work/seed-2.31.91'
gmake: *** [all] Error 2
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop in /usr/ports/devel/seed.



>How-To-Repeat:

	Upgrade readline to version 6.3 and attempt to build devel/seed.

>Fix:


	Drop the following patch into devel/seed/files/

--- modules/readline/seed-readline.c.orig	2010-08-30 14:37:39.000000000 -0700
+++ modules/readline/seed-readline.c	2014-03-23 15:16:40.000000000 -0700
@@ -77,7 +77,7 @@
   key = seed_value_to_string(ctx, arguments[0], exception);
   c = seed_make_rl_closure((SeedObject) arguments[1]);
 
-  rl_bind_key(*key, (Function *) c);
+  rl_bind_key(*key, (rl_hook_func_t *) c);
 
   g_free(key);
 
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201403240006.s2O06YLZ064514>