Date: Wed, 2 Nov 2016 08:53:05 +0100 From: Dimitry Andric <dim@FreeBSD.org> To: Antoine Brodin <antoine@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, Ed Maste <emaste@freebsd.org>, Jonathan Anderson <jonathan@FreeBSD.org> Subject: Re: svn commit: r308181 - in head: . share/mk Message-ID: <459BD98A-4788-497E-B2D5-5EC20C5B9EE8@FreeBSD.org> In-Reply-To: <69A64340-FE51-4AF0-9905-B46220D041E9@FreeBSD.org> References: <201611012127.uA1LRg0B045900@repo.freebsd.org> <46715A69-03C5-404F-B133-C8FE89D59A9B@FreeBSD.org> <69A64340-FE51-4AF0-9905-B46220D041E9@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_5010B624-4795-4995-8532-CD3F6C39A9D9
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=us-ascii
On 02 Nov 2016, at 08:25, Jonathan Anderson <jonathan@FreeBSD.org> =
wrote:
>=20
> On 1 Nov 2016, at 21:10, Dimitry Andric wrote:
>=20
>> Please note, I reverted r307823 (which changed the suffixes from .bco
>> and .llo to .bc and .ll) in r308003, since it caused a number of =
ports
>> failures. These ports were already using .ll as a suffix for C++ lex
>> scripts.
>=20
> The changes to bsd.suffixes-posix.mk (included by sys.mk) would have =
affected anything compiled with bmake, and indeed, I'd imagine that =
adding a .c->.ll rule alongside .c->.o could cause problems with C++ lex =
rules. In fact, part of brooks' original motivation for introducing .llo =
suffixes was to avoid name conflicts (although conflicts with program IR =
like we're introducing in this commit). The changes in this commit =
should only be picked up by things that explicit include =
bsd.{lib,prog}.mk, however, and they also have slightly more esoteric =
names (e.g., progname.full.ll) that are less likely to cause a conflict. =
Perhaps I ought to have done an exp-run, but I suspect that this commit =
will cause much less / no fallout. I don't suppose you have a list of =
the ports that failed after your r307823 change so that I could do spot =
checks?
Hi Antoine, you pointed me at some of these port failures due to the .ll
change, do you still have a list of them?
-Dimitry
--Apple-Mail=_5010B624-4795-4995-8532-CD3F6C39A9D9
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.30
iEYEARECAAYFAlgZm2UACgkQsF6jCi4glqPF/wCghI2Bzv/tDpoLiWG6MUOss4/t
qFQAn0tj6GxNxmdXvMVwezZJQBZdfKTO
=drqb
-----END PGP SIGNATURE-----
--Apple-Mail=_5010B624-4795-4995-8532-CD3F6C39A9D9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?459BD98A-4788-497E-B2D5-5EC20C5B9EE8>