Date: Sun, 21 Feb 2010 07:24:18 -0500 From: Wesley Shields <wxs@FreeBSD.org> To: Dominic Fandrey <kamikaze@bsdforen.de> Cc: Christer Solskogen <christer.solskogen@gmail.com>, ports@freebsd.org Subject: Re: make package-noinstall does not include rc.d scripts? Message-ID: <20100221122418.GA94133@atarininja.org> In-Reply-To: <4B81129E.5040401@bsdforen.de> References: <c1a0d1561002200755q4ab28515ic550fca1789e1cd8@mail.gmail.com> <4B80EAD4.1070109@bsdforen.de> <c1a0d1561002210133x3de590a4ie40c4da15c78695d@mail.gmail.com> <4B81006D.2000906@bsdforen.de> <c1a0d1561002210147k172783ffya9f0ae68d6c5ffa4@mail.gmail.com> <4B81049A.8060400@bsdforen.de> <4B81129E.5040401@bsdforen.de>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 21, 2010 at 12:01:50PM +0100, Dominic Fandrey wrote: > On 21/02/2010 11:02, Dominic Fandrey wrote: > > On 21/02/2010 10:47, Christer Solskogen wrote: > >> On Sun, Feb 21, 2010 at 10:44 AM, Dominic Fandrey <kamikaze@bsdforen.de> wrote: > >> > >>> So the right solution might be for the "package-noinstall" target to > >>> use "pkg_create -b" and additionally create the symlinks. > >>> > >>> I do not like have different code for doing the same thing in this > >>> context. > >> > >> Does the target 'package' use pkg_create? > > > > Yes it does. > > More precisely, do-package does. > > > I have a patch that should do the trick. Would you be so kind to test > > it? > > http://www.home.hs-karlsruhe.de/~fado0001/patch-ports-Mk-bsd.port.mk.txt > > > > If it does, please open a PR and post the number here. wxs and I can > > post our patches there and portmgr can decide. > > After testing my patch to my satisfaction I went ahead and opened a PR: > http://www.freebsd.org/cgi/query-pr.cgi?pr=144164 No need for my patch to make it into the PR. I like your solution better. ;) -- WXS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100221122418.GA94133>