Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Feb 2014 18:26:09 +0400 (MSK)
From:      Dmitry Marakasov <amdmi3@FreeBSD.org>
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/187084: [bsd.port.mk] only display " - found" for library once
Message-ID:  <20140226142609.ACCEC187CC@hades.panopticon>
Resent-Message-ID: <201402261450.s1QEo00W069289@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         187084
>Category:       ports
>Synopsis:       [bsd.port.mk] only display " - found" for library once
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 26 14:50:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Dmitry Marakasov
>Release:        FreeBSD 10.0-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD hades.panopticon 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260807: Fri Jan 17 13:14:28 MSK 2014 root@hades.panopticon:/usr/obj/usr/src/sys/HADES amd64


>Description:
LIB_DEPENDS check searches for a library in each of ldconfig directories.
Sometimes that leads to library being found twice. For example,
on 10.x there is /usr/lib/libexecinfo.so, however
/usr/local/lib/libexecinfo.so may also be installed with the port.
This leads to (harmless) bogus message:

---
===>   testport-0 depends on file: /usr/local/sbin/pkg - found
===> Fetching all distfiles required by testport-0 for building
===>  Extracting for testport-0
===>  Patching for testport-0
===>   testport-0 depends on shared library: libexecinfo.so - found
 - found
===>  Configuring for testport-0
---

Attached patch changes bsd.port.mk to only print " - found" once.

>How-To-Repeat:
On 10.x with installed libexecinfo, make something which depends on libexecinfo.
>Fix:

--- patch-bsd.port.mk begins here ---
Index: bsd.port.mk
===================================================================
--- bsd.port.mk	(revision 346206)
+++ bsd.port.mk	(working copy)
@@ -4974,9 +4974,10 @@
 				[ `file -b -L --mime-type $${_LIB_FILE}` = "application/x-sharedlib" ] || continue ; \
 			fi ; \
 			found=1 ; \
+		done ; \
+		if [ $${found} -eq 1 ]; then \
 			${ECHO_MSG} " - found"; \
-		done ; \
-		if [ $${found} -eq 0 ]; then \
+		else \
 			${ECHO_MSG} " - not found"; \
 			${ECHO_MSG} "===>    Verifying for $$lib in $$dir"; \
 			if [ ! -d "$$dir" ] ; then \
--- patch-bsd.port.mk ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140226142609.ACCEC187CC>