Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 24 Mar 2014 22:08:54 -0400 (EDT)
From:      Adam Weinberger <adamw@FreeBSD.org>
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/187914: [patch] make www/owncloud optional dependencies optional
Message-ID:  <20140325020854.097C011F995@apnoea.adamw.org>
Resent-Message-ID: <201403250210.s2P2A0K7009430@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         187914
>Category:       ports
>Synopsis:       [patch] make www/owncloud optional dependencies optional
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 25 02:10:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Adam Weinberger
>Release:        FreeBSD 10.0-STABLE i386
>Organization:
>Environment:
System: FreeBSD apnoea.adamw.org 10.0-STABLE FreeBSD 10.0-STABLE #0: Sun Mar 23 08:42:36 EDT 2014 root@apnoea.adamw.org:/usr/obj/usr/src/sys/PEEP i386


>Description:

Some of the optional dependencies for www/owncloud that are hardcoded
are by no means lightweight... mp3info and php5-ldap especially. They
are not necessary for running owncloud and are easily placed behind
some OPTIONS.

The attached patch turns some of these things into OPTIONS, and defaults
them to ON so that the net sum for packaging is still the same.

>How-To-Repeat:
>Fix:


--- owncloud.patch begins here ---
Index: Makefile
===================================================================
--- Makefile	(revision 348808)
+++ Makefile	(working copy)
@@ -11,12 +11,9 @@
 
 LICENSE=	AGPLv3
 
-BUILD_DEPENDS=	mp3info:${PORTSDIR}/audio/mp3info
-RUN_DEPENDS:=	${BUILD_DEPENDS}
-
 USE_BZIP2=	yes
-USE_PHP=	bz2 ctype curl dom exif fileinfo filter gd hash iconv json \
-		ldap mbstring openssl pdo session simplexml xml xmlreader \
+USE_PHP=	bz2 ctype curl dom fileinfo filter gd hash iconv json \
+		mbstring pdo session simplexml xml xmlreader \
 		xsl wddx zip zlib
 WANT_PHP_WEB=	yes
 
@@ -29,12 +26,20 @@
 PLIST_SUB=	OWNCLOUD_USERNAME=${OWNCLOUD_USERNAME} \
 		OWNCLOUD_GROUPNAME=${OWNCLOUD_GROUPNAME}
 
+OPTIONS_DEFINE=	EXIF LDAP MP3INFO SSL
 OPTIONS_MULTI=	DB
 OPTIONS_MULTI_DB=	MYSQL PGSQL SQLITE
-OPTIONS_DEFAULT=	SQLITE
+OPTIONS_DEFAULT=	EXIF LDAP MP3INFO SQLITE SSL
+EXIF_DESC=	Image rotation support
+MP3INFO_DESC=	MP3 ID3 tags support
+EXIF_USE=	PHP=exif
+LDAP_USE=	PHP=ldap
+MP3INFO_BUILD_DEPENDS=	mp3info:${PORTSDIR}/audio/mp3info
+MP3INFO_RUN_DEPENDS=	${MP3INFO_BUILD_DEPENDS}
 MYSQL_USE=	MYSQL=client PHP=mysql,pdo_mysql
 PGSQL_USE=	PGSQL=yes PHP=pdo_pgsql,pgsql
 SQLITE_USE=	PHP=pdo_sqlite,sqlite3
+SSL_USE=	PHP=openssl
 
 do-install:
 	@${MKDIR} -m 0755 ${STAGEDIR}${WWWDIR}
--- owncloud.patch ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140325020854.097C011F995>