Date: Sat, 22 Nov 2003 12:37:59 -0500 (EST) From: Robert Watson <rwatson@FreeBSD.org> To: "Brian F. Feldman" <green@FreeBSD.org> Cc: Perforce Change Reviews <perforce@FreeBSD.org> Subject: Re: PERFORCE change 42907 for review Message-ID: <Pine.NEB.3.96L.1031122123614.47771A-100000@fledge.watson.org> In-Reply-To: <200311220338.hAM3cPvP025379@green.bikeshed.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 21 Nov 2003, Brian F. Feldman wrote:
> > @@ -204,7 +202,16 @@
> >
> > sudo make install
> >
> > - XXX: rename WindowServer, etc.
> > + In order to run the WindowServer in our modified environment, you must
> > + replace the existing WindowServer binary with our wrapper. NOTE:
> > + It is extremely important that these commands be executed cautiously:
> > + the new name for the old WindowServer must be RealWindowServer, and
> > + you really don't want to fail to rename before you install the new
> > + one, or you end up with no WindowServer at all:
> > +
> > + sudo mv /System/Library/CoreServices/WindowServer \
> > + /System/Library/CoreServices/RealWindowServer
> > + sudo make install-window-server-wrapper
>
> cspath="/System/Library/CoreServices"
> if sudo mv "${cspath}/WindowServer" "${cspath/}RealWindowServer"; then
> if ! sudo make install-window-server-wrapper || \
> test ! -e "${cspath}/WindowServer"; then
> sudo mv "${cspath}/RealWindowServer" "${cspath}/WindowServer"
> fi
> fi
>
> or something...
Two complicating factors:
(1) Darwin uses gmake, not BSD make
(2) We also want a test in there to make sure that WindowServer is rotated
out once -- i.e., if you already have a RealWindowServer, we don't
rotate. Probably I should just add a make rule rule with a
RealWindowServer target that is satisfied if the rename has already
taken place.
Should definitely automate this step -- the risks of failure are pretty
nasty (Oh, I'm sorry, did we break your windowing system on an OS where
you need the windowing system to log in by default?).
Robert N M Watson FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org Network Associates Laboratories
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1031122123614.47771A-100000>