Date: Tue, 21 Jan 2003 19:49:30 +0100 From: Thomas Moestl <tmm@FreeBSD.org> To: Sam Leffler <sam@errno.com> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sparc64/sparc64 iommu.c Message-ID: <20030121184930.GA337@crow.dom2ip.de> In-Reply-To: <04bf01c2c178$4cc3eca0$52557f42@errno.com> References: <200301211708.h0LH8Mn5005942@repoman.freebsd.org> <04bf01c2c178$4cc3eca0$52557f42@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 2003/01/21 at 10:09:54 -0800, Sam Leffler wrote: > > Fix iommu_dvmamap_sync(): it was still operating as if the BUS_DMASYNC_* > > constants where flag bits (as in NetBSD), although they are > consecutively > > numbered in FreeBSD. This would cause unnecessary flushing in the > > BUS_DMASYNC_POSTWRITE case, but was otherwise mostly harmless. [...] > > Gack! Do you see a good reason for this? This seems like something that'll > cause really hard to find bugs when porting drivers (though one should > probably not use more than one flag per op). I'd really like to see these > constants have the same value on all systems. Moving in the direction of NetBSD definitely makes sense here, I just wanted to fix this breakage as quickly as possible for now. - Thomas -- Thomas Moestl <tmoestl@gmx.net> http://www.tu-bs.de/~y0015675/ <tmm@FreeBSD.org> http://people.FreeBSD.org/~tmm/ PGP fingerprint: 1C97 A604 2BD0 E492 51D0 9C0F 1FE6 4F1D 419C 776C To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030121184930.GA337>