Date: Wed, 09 Jan 2013 02:29:23 -0500 From: "Jason E. Hale" <jhale@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r310110 - in head: . mail/perdition mail/perdition/files Message-ID: <1684549.OSdhx2gJ5Y@mocha.verizon.net> In-Reply-To: <20130109000747.GH85686@ithaqua.etoilebsd.net> References: <201301082233.r08MXBtn030900@svn.freebsd.org> <20130109000747.GH85686@ithaqua.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, January 09, 2013 01:07:48 Baptiste Daroussin wrote: > On Tue, Jan 08, 2013 at 10:33:11PM +0000, Jason E. Hale wrote: > > +OPTIONS_DEFINE= BDB DAEMON_MAP GDBM MYSQL NIS ODBC OPENLDAP OPENSSL > > PGSQL POSIX_REGEX SSL > The last SSL is unused in the rest of the port, it can probably be removed. > Thanks, I missed that. > Why not appending DOCS given that the dialog will be shown anyway? While I > do understand that people do not create an OPTIONS_DEFINE just for DOCS do > avoid prompting the dialog all the time, I do think that if there is > already an OPTIONS_DEFINE then it is worth appending DOCS to it. > > > +OPTIONS_DEFAULT= GDBM POSIX_REGEX SSL > > I agree, I'll add it. > > -.if !defined(WITHOUT_SSL) > > +DAEMON_MAP_DESC= Daemon Map support > > +GDBM_DESC= GDBM database backend > > That probalbly deserves a generic definition as it is wildly used in the > ports tree > There is already a generic definition for GDBM, but it didn't make sense for this port. "GNU dbm library" isn't very descriptive IMO. > > +NIS_DESC= NIS database backend > > This can problem be deneric definition (bsd.options.desc.mk) > Maybe, but I don't think this description would be fitting for most ports anyways. For this port it is meant to enable a module that reads a NIS map as the database, from what I understand. Perhaps "Network Information Service/YP support" for a generic description? > > +OPENLDAP_DESC= OpenLDAP database backend > > Why not using LDAP instead of OPENLDAP? > I wasn't aware of it...I'll change it. -- Jason E. Hale - jhale@ FreeBSD Ports Committer KDE/FreeBSD Team
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1684549.OSdhx2gJ5Y>